[GitHub] [spark] shahidki31 commented on a change in pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter

[GitBox <gi...@apache.org>]

shahidki31 commented on a change in pull request #20793: [WIP][SPARK-23643] Shrinking the buffer in hashSeed up to size of the seed parameter
URL: https://github.com/apache/spark/pull/20793#discussion_r265440799
 
 

 ##########
 File path: mllib/src/test/scala/org/apache/spark/ml/clustering/PowerIterationClusteringSuite.scala
 ##########
 @@ -86,7 +86,10 @@ class PowerIterationClusteringSuite extends SparkFunSuite
     assignments.foreach {
       case (id, cluster) => predictions(cluster) += id
     }
-    assert(predictions.toSet === Set((0 until n1).toSet, (n1 until n).toSet))
+    assert(predictions.toSet === Set(
+      Set(0, 30, 9, 1, 31, 2, 32, 24, 3, 25, 4, 26, 27, 19, 20, 21, 22, 23, 16, 17,
+          18, 33, 34, 5, 35, 6, 36, 28, 7, 29, 8),
+      Set(15, 45, 37, 46, 38, 39, 10, 40, 47, 11, 41, 48, 12, 13, 49, 42, 43, 14, 44)))
 
 Review comment:
   @MaxGekk , I think we cannot simply change the expected value like this.
   Basically, we create 2 circles: Outer circle has 40 points and inner circle has 10 points. So, PIC should return a cluster size of 10 and 40 respectively, if the algorithm work properly
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org