[GitHub] [spark] cloud-fan commented on a diff in pull request #42587: [SPARK-44897][SQL] Propagating local properties to subquery broadcast exec

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #42587:
URL: https://github.com/apache/spark/pull/42587#discussion_r1305262000


##########
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala:
##########
@@ -191,6 +191,52 @@ class ExecutorSideSQLConfSuite extends SparkFunSuite with SQLTestUtils {
       assert(checks2.forall(_.toSeq == Seq(true, true)))
     }
   }
+
+  test("SPARK-44897 propagate local properties to subquery broadcast execuction thread") {

Review Comment:
   if this test can't reproduce the bug directly, we can put it in the PR descriptions with instructions about the extra change to reproduce the bug (add sleep).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org