You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/11/26 13:39:19 UTC

[GitHub] [lucene-solr] dsmiley commented on issue #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching

dsmiley commented on issue #1037: LUCENE-9062: QueryVisitor.consumeTermsMatching
URL: https://github.com/apache/lucene-solr/pull/1037#issuecomment-558632360
 
 
   With this change, it's interesting to see CharacterRunAutomaton will be even more niche... relegated to use with RegExp in non-test uses; no longer in the highlighter.  Maybe CharacterRunAutomaton could use a bit more clarification that the Automata it operates on is a UTF32 code point Automaton, not some other type (not bytes/256).  Furthermore Regexp.toAutomaton could document that.  Our Automata is sadly untyped but they are not equivalent!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org