You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/04/16 03:15:08 UTC
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10074
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
[java] Use gradle caching now that it is stable in 4.6
Additionally removes protobug intellij mapping now that
it’s done by default, and fixes a warning about leaked
annotation processors when building.
Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
---
M build-support/jenkins/build-and-test.sh
M java/gradle.properties
M java/gradle/compile.gradle
M java/gradle/protobuf.gradle
4 files changed, 3 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/10074/1
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> If you think there is risk in the space being used, I am happy to leave it
We discussed this over Slack but I'll restate my position here for the benefit of others: until we can convince ourselves that the build time savings are significant, I think we should ensure this is opt-in like ccache.
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 20:19:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> Yeah similar to ccache. Unfortunately in 4.6 the size control is by time. I
BTW, how much build time does shave off? Can you measure twice: once excluding tests, and once including them?
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:52:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> BTW, how much build time does shave off? Can you measure twice: once exclud
It's hard to measure exactly. Gradle will prevent the rebuild of existing code today without this. What this speeds up is the case where you switch a branch and some of the modules changed and some didn't. Or you switch back to a branch you were just working on. Instead of rebuilding everything it can use past "outputs" of tasks given their "inputs" are the same, essentially only building exactly what is different or new and picking up where you left off.
Here are the times from 2 builds without tests that don't use the build cache, but also don't rebuild if not necessary.
gradle clean assemble --no-build-cache
BUILD SUCCESSFUL in 2m 2s
75 actionable tasks: 75 executed
gradle assemble --no-build-cache
BUILD SUCCESSFUL in 1s
68 actionable tasks: 68 up-to-date
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 19:07:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle 4.6 upgrade follow up
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Gradle 4.6 upgrade follow up
......................................................................
Patch Set 3:
Updated the patch to include all the small follow up fixes, but drop the build cache change.
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 20:23:44 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> It's hard to measure exactly. Gradle will prevent the rebuild of existing c
I didn't know this was a problem we had; to my untrained eye, the Gradle "build" (excluding test runtime) was already quite fast. That's why I asked you to quantify it. Two minutes is nothing to sneeze at, but as you showed, Gradle's basic incremental building support is good enough to reclaim that time.
So I guess I'm still struggling to qualify whether this trade-off is worth it. We're talking about space consumed outside of the build output directory, and naive Gradle users won't know how to find that. Even just a few GBs can have an impact on a small SSD. At least ccache is opt-in so you have to be aware of it in order to make its space/time trade-off.
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 19:21:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle 4.6 upgrade follow up
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10074
to look at the new patch set (#3).
Change subject: [java] Gradle 4.6 upgrade follow up
......................................................................
[java] Gradle 4.6 upgrade follow up
- Removes protobuf intellij mapping now that
it’s done by default
- Fixes a warning about leaked annotation processors
when building.
Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
---
M java/gradle/compile.gradle
M java/gradle/protobuf.gradle
2 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/10074/3
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Dan Burkert, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10074
to look at the new patch set (#2).
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
[java] Use gradle caching now that it is stable in 4.6
Enabling the Gradle build cache can drastically speed up
local development by reusing outputs produced by other builds.
More about the Gradle build cache can be read here:
https://docs.gradle.org/current/userguide/build_cache.html
Additionally removes protobuf intellij mapping now that
it’s done by default, and fixes a warning about leaked
annotation processors when building.
Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
---
M build-support/jenkins/build-and-test.sh
M java/gradle.properties
M java/gradle/compile.gradle
M java/gradle/protobuf.gradle
4 files changed, 7 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/10074/2
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> Okay, so it's morally equivalent to ccache? I read the docs but it doesn't
Yeah similar to ccache. Unfortunately in 4.6 the size control is by time. It's weird, but they removed the targetSizeInMB configuration in 4.5. It was defaulted to 5 GB.
4.5 configs: https://docs.gradle.org/4.5/dsl/org.gradle.caching.local.DirectoryBuildCache.html#org.gradle.caching.local.DirectoryBuildCache:targetSizeInMB
4.6 configs: https://docs.gradle.org/4.6/dsl/org.gradle.caching.local.DirectoryBuildCache.html#org.gradle.caching.local.DirectoryBuildCache:targetSizeInMB
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:48:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle 4.6 upgrade follow up
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Gradle 4.6 upgrade follow up
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 20:27:51 +0000
Gerrit-HasComments: No
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> What's the motivation? Can you explain in the commit message?
Done
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@9
PS1, Line 9: protobug
> protobuf?
Done
http://gerrit.cloudera.org:8080/#/c/10074/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/10074/1/build-support/jenkins/build-and-test.sh@390
PS1, Line 390: GRADLE_FLAGS="$GRADLE_FLAGS --console=plain --no-daemon --no-build-cache"
> Why disable the daemon and caching here? Can you add a comment?
I don't have too but I used it for build isolation. I will add a comment.
http://gerrit.cloudera.org:8080/#/c/10074/1/java/gradle/compile.gradle
File java/gradle/compile.gradle:
http://gerrit.cloudera.org:8080/#/c/10074/1/java/gradle/compile.gradle@26
PS1, Line 26: options.compilerArgs << '-proc:none' // Ignore leaked annotation processors on the compile classpath.
> What does that error actually mean? What does "leaking" mean in this contex
To see the warning output from gradle run a build on the kudu-hive project without this line. Essentially a transitive dependency somewhere in the stack added an annotation processor that should not be there. Since we don't sue them we are ignoring them.
Here is the gradle documentation on the issue: https://docs.gradle.org/4.6/release-notes.html#putting-annotation-processors-on-the-compile-classpath-or-explicit--processorpath-compiler-argument
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:28:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Gradle 4.6 upgrade follow up
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Gradle 4.6 upgrade follow up
......................................................................
[java] Gradle 4.6 upgrade follow up
- Removes protobuf intellij mapping now that
it’s done by default
- Fixes a warning about leaked annotation processors
when building.
Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Reviewed-on: http://gerrit.cloudera.org:8080/10074
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M java/gradle/compile.gradle
M java/gradle/protobuf.gradle
2 files changed, 1 insertion(+), 7 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
What's the motivation? Can you explain in the commit message?
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@9
PS1, Line 9: protobug
protobuf?
http://gerrit.cloudera.org:8080/#/c/10074/1/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/10074/1/build-support/jenkins/build-and-test.sh@390
PS1, Line 390: GRADLE_FLAGS="$GRADLE_FLAGS --console=plain --no-daemon --no-build-cache"
Why disable the daemon and caching here? Can you add a comment?
http://gerrit.cloudera.org:8080/#/c/10074/1/java/gradle/compile.gradle
File java/gradle/compile.gradle:
http://gerrit.cloudera.org:8080/#/c/10074/1/java/gradle/compile.gradle@26
PS1, Line 26: options.compilerArgs << '-proc:none' // Ignore leaked annotation processors on the compile classpath.
What does that error actually mean? What does "leaking" mean in this context?
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:16:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> I didn't know this was a problem we had; to my untrained eye, the Gradle "b
If you think there is risk in the space being used, I am happy to leave it disabled by default. I was enabling it because I saw it as low risk and it was marked stable in 4.6. I see it as a benefit to developers that are changing branches frequently to save some time, but they can enable it themselves if they want to use the feature.
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 19:36:58 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] Use gradle caching now that it is stable in 4.6
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10074 )
Change subject: [java] Use gradle caching now that it is stable in 4.6
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/10074/1//COMMIT_MSG@7
PS1, Line 7: [java] Use gradle caching now that it is stable in 4.6
> Done
Okay, so it's morally equivalent to ccache? I read the docs but it doesn't say whether there's an upper bound on space consumed by the build cache, just that entries older than a certain time (default 7 days) will be pruned. Do you know if there is such an upper bound?
--
To view, visit http://gerrit.cloudera.org:8080/10074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5cc3c7a1263b085511c825118fb814e1b65008
Gerrit-Change-Number: 10074
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 18:33:56 +0000
Gerrit-HasComments: Yes