You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "Gus Heck (Jira)" <ji...@apache.org> on 2022/11/16 03:13:00 UTC
[jira] [Created] (SOLR-16550) Factor excludes and close shielding out of Dispatch filter
Gus Heck created SOLR-16550:
-------------------------------
Summary: Factor excludes and close shielding out of Dispatch filter
Key: SOLR-16550
URL: https://issues.apache.org/jira/browse/SOLR-16550
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Gus Heck
Continuing the quest to simplify the SolrDispatchFilter this ticket will go for some low hanging fruit by creating a filter to apply our close shields on the request and response objects. To make this new filter truly composable with SolrDispatch and any other filter the excludes logic will be moved to the BaseSolrFilter class and ensure that we never check excludes more than once for a static resource matching the exclude pattern. excludes also seems better named staticResources to more accurately describe its function. (conceivably we might also want a skip feature which just skips a particular filter later).
One thing that has held me back on changes like this this is that I didn't want to make this type of change without validating performance impact. Hopefully SOLR-16525 will make such an assessment much easier.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org