[GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1650: [HUDI-541]: replaced dataFile/df with baseFile/bf throughout code base

[GitBox <gi...@apache.org>]

bvaradar commented on a change in pull request #1650:
URL: https://github.com/apache/incubator-hudi/pull/1650#discussion_r429412110



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/RocksDBSchemaHelper.java
##########
@@ -78,12 +78,12 @@ public String getPrefixForSliceViewByPartitionFile(String partitionPath, String
     return String.format("type=slice,part=%s,id=%s,instant=", partitionPath, fileId);
   }
 
-  public String getPrefixForDataFileViewByPartitionFile(String partitionPath, String fileId) {
-    return String.format("type=df,part=%s,id=%s,instant=", partitionPath, fileId);
+  public String getPrefixForBaseFileViewByPartitionFile(String partitionPath, String fileId) {
+    return String.format("type=bf,part=%s,id=%s,instant=", partitionPath, fileId);

Review comment:
       Yes, this is currently transient. It is fine.

##########
File path: hudi-common/src/main/avro/HoodieCompactionOperation.avsc
##########
@@ -41,7 +41,7 @@
                      "default": null
                   },
                   {
-                     "name":"dataFilePath",
+                     "name":"baseFilePath",

Review comment:
       @pratyakshsharma : Instead of renaming fields, add an alias ?
   
   http://bigdatafindings.blogspot.com/2016/05/schema-evolution-with-avro.html

##########
File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CompactionCommand.java
##########
@@ -370,7 +370,7 @@ private String printCompaction(HoodieCompactionPlan compactionPlan,
     List<Comparable[]> rows = new ArrayList<>();
     if ((null != compactionPlan) && (null != compactionPlan.getOperations())) {
       for (HoodieCompactionOperation op : compactionPlan.getOperations()) {
-        rows.add(new Comparable[]{op.getPartitionPath(), op.getFileId(), op.getBaseInstantTime(), op.getDataFilePath(),
+        rows.add(new Comparable[]{op.getPartitionPath(), op.getFileId(), op.getBaseInstantTime(), op.getBaseFilePath(),

Review comment:
       Yes, the name is serialized. @pratyakshsharma : Instead of renaming , can you add alias to the field and see if that works ?

##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/RemoteHoodieTableFileSystemView.java
##########
@@ -71,18 +71,18 @@
 
   public static final String PENDING_COMPACTION_OPS = String.format("%s/%s", BASE_URL, "compactions/pending/");
 
-  public static final String LATEST_PARTITION_DATA_FILES_URL =
-      String.format("%s/%s", BASE_URL, "datafiles/latest/partition");
-  public static final String LATEST_PARTITION_DATA_FILE_URL =
-      String.format("%s/%s", BASE_URL, "datafile/latest/partition");
-  public static final String ALL_DATA_FILES = String.format("%s/%s", BASE_URL, "datafiles/all");
-  public static final String LATEST_ALL_DATA_FILES = String.format("%s/%s", BASE_URL, "datafiles/all/latest/");
-  public static final String LATEST_DATA_FILE_ON_INSTANT_URL = String.format("%s/%s", BASE_URL, "datafile/on/latest/");
-
-  public static final String LATEST_DATA_FILES_RANGE_INSTANT_URL =
-      String.format("%s/%s", BASE_URL, "datafiles/range/latest/");
-  public static final String LATEST_DATA_FILES_BEFORE_ON_INSTANT_URL =
-      String.format("%s/%s", BASE_URL, "datafiles/beforeoron/latest/");
+  public static final String LATEST_PARTITION_BASE_FILES_URL =
+      String.format("%s/%s", BASE_URL, "basefiles/latest/partition");

Review comment:
       Yes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org