You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/07 10:03:37 UTC
[GitHub] [incubator-iotdb] Alima777 opened a new pull request #1166: [IOTDB-642] Data can't be inserted correctly by alias
Alima777 opened a new pull request #1166:
URL: https://github.com/apache/incubator-iotdb/pull/1166
If data is inserted using alias, it will be stored by alias path which leads to the empty result in query.
set storage group to root.sg;
create timeseries root.sg.d1.s1(speed)with datatype=FLOAT, encoding=RLE;
insert into root.sg.d1(timestamp,speed) values(1,1);
select s1 from root.sg.d1;
select speed from root.sg.d1;
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] Alima777 commented on a change in pull request #1166: [IOTDB-642] Data can't be inserted correctly by alias
Posted by GitBox <gi...@apache.org>.
Alima777 commented on a change in pull request #1166:
URL: https://github.com/apache/incubator-iotdb/pull/1166#discussion_r421918107
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##########
@@ -871,8 +871,12 @@ public void insert(InsertPlan insertPlan) throws QueryProcessException {
}
LeafMNode measurementNode = (LeafMNode) node.getChild(measurement);
schemas[i] = measurementNode.getSchema();
+ if (measurement != measurementNode.getName()){
Review comment:
Fixed~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1166: [IOTDB-642] Data can't be inserted correctly by alias
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #1166:
URL: https://github.com/apache/incubator-iotdb/pull/1166#discussion_r421891787
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java
##########
@@ -871,8 +871,12 @@ public void insert(InsertPlan insertPlan) throws QueryProcessException {
}
LeafMNode measurementNode = (LeafMNode) node.getChild(measurement);
schemas[i] = measurementNode.getSchema();
+ if (measurement != measurementNode.getName()){
Review comment:
```suggestion
schemas[i] = measurementNode.getSchema();
if (measurement != measurementNode.getName()) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org