You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/05/04 07:40:10 UTC

[GitHub] [bookkeeper] eolivelli commented on a diff in pull request #3255: Allow run LocalBookkeeper directly in `bookkeeper-server` module or on IDE

eolivelli commented on code in PR #3255:
URL: https://github.com/apache/bookkeeper/pull/3255#discussion_r864534753


##########
bookkeeper-server/pom.xml:
##########
@@ -123,6 +123,19 @@
       <groupId>io.reactivex.rxjava3</groupId>
       <artifactId>rxjava</artifactId>
     </dependency>
+    <!-- used on test and main method like `LocalBookKeeper` -->
+    <dependency>
+      <!-- needed by ZooKeeper server -->
+      <groupId>org.xerial.snappy</groupId>
+      <artifactId>snappy-java</artifactId>
+      <scope>runtime</scope>

Review Comment:
   is this dependency imported to downstream client applications ?
   did you test it ?
   
   probably we will need to add "optional"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org