You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/19 16:38:55 UTC
[GitHub] [arrow] pitrou opened a new pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
pitrou opened a new pull request #7225:
URL: https://github.com/apache/arrow/pull/7225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques closed pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
Posted by GitBox <gi...@apache.org>.
fsaintjacques closed pull request #7225:
URL: https://github.com/apache/arrow/pull/7225
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7225:
URL: https://github.com/apache/arrow/pull/7225#issuecomment-630943041
That requires passing the "consumer ID" somehow. Perhaps in the AsyncContext?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #7225:
URL: https://github.com/apache/arrow/pull/7225#discussion_r428583281
##########
File path: cpp/src/arrow/io/interfaces.h
##########
@@ -51,6 +51,8 @@ struct ReadRange {
// EXPERIMENTAL
struct ARROW_EXPORT AsyncContext {
::arrow::internal::Executor* executor;
+ // An application-specific ID, forwarded to executor task submissions
+ int64_t external_id = -1;
Review comment:
@lidavidm Is `int64_t` sufficient here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on a change in pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on a change in pull request #7225:
URL: https://github.com/apache/arrow/pull/7225#discussion_r428607341
##########
File path: cpp/src/arrow/io/interfaces.h
##########
@@ -51,6 +51,8 @@ struct ReadRange {
// EXPERIMENTAL
struct ARROW_EXPORT AsyncContext {
::arrow::internal::Executor* executor;
+ // An application-specific ID, forwarded to executor task submissions
+ int64_t external_id = -1;
Review comment:
It should, the other option is to pass a `void *`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7225:
URL: https://github.com/apache/arrow/pull/7225#issuecomment-630953755
> That requires passing the "consumer ID" somehow. Perhaps in the AsyncContext?
Yeah, that would make sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7225: ARROW-8847: [C++] Pass task hints in Executor API
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7225:
URL: https://github.com/apache/arrow/pull/7225#issuecomment-630943986
https://issues.apache.org/jira/browse/ARROW-8847
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org