You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/02/23 23:04:50 UTC
[GitHub] [netbeans] GitHubb3R opened a new pull request #1968: NETBEANS-3575
initial implementation.
GitHubb3R opened a new pull request #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] GitHubb3R commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
GitHubb3R commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-612507431
Sorry about that, I think I managed to correct the real name issue.
Is it OK if I'd like to keep my email hidden?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] GitHubb3R commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
GitHubb3R commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-613567061
Okay, if I configured things properly it should not be hidden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-613495603
Sorry, no correct author information is required. For larger contributions the ASF even requires an signed ICLA. For small contributions we are already relaxing the rules, but we still need to be able to determine the author.
The above is true for the git history (although that is public), you can keep your name out of the github profile, to do so see here:
https://github.com/apache/netbeans/pull/2061#issuecomment-612475333
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] GitHubb3R commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
GitHubb3R commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-612422394
> The JIRA report is good, we just need a short summary for the git log as well. E.g. use title "[NETBEANS-3575] Fix ordering of j2ee.platform.classpath entires" for the commit title and a shorter summary of the bug in the commit description.
>
Thank you for the clarification! I've amended the commit in a way you requested.
> Also check that you have a real name/email in the git commit. (I'm not sure how to check this from the GitHub interface... but I remember we've had trouble with getting this info correct in the past once we merge the PR.)
>
I have no idea how to check this, or by checking so I would have no idea what I would be doing :)
But in any case the corresponding git properties should be configured properly. Furthermore GitHub doesn't let me push unless I'm logged in. Obviously I did not try a configuration that does not much the login information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-612315195
The JIRA report is good, we just need a short summary for the git log as well. E.g. use title "[NETBEANS-3575] Fix ordering of j2ee.platform.classpath entires" for the commit title and a shorter summary of the bug in the commit description.
Also check that you have a real name/email in the git commit. (I'm not sure how to check this from the GitHub interface... but I remember we've had trouble with getting this info correct in the past once we merge the PR.)
The code changes look good--thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-611718182
This one will need a better commit title and description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-612470843
The author information is partially ok - the email is present and looks correct, the real name though does not. You can use the git command to see the information:
`git log -n 3`
Shows the last three commits.
This PR must not be squashed, as the author information in the github profile is not public and thus will cause invalid author information on the squashed commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] GitHubb3R commented on issue #1968: NETBEANS-3575
initial implementation.
Posted by GitBox <gi...@apache.org>.
GitHubb3R commented on issue #1968: NETBEANS-3575 initial implementation.
URL: https://github.com/apache/netbeans/pull/1968#issuecomment-612244723
> This one will need a better commit title and description.
Does the original JIRA ticket suffice?
https://issues.apache.org/jira/browse/NETBEANS-3575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists