You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Valentin Valchev (JIRA)" <ji...@apache.org> on 2010/02/23 15:20:27 UTC

[jira] Created: (FELIX-2125) Localization of the bundle headers & bundle name

Localization of the bundle headers & bundle name
------------------------------------------------

                 Key: FELIX-2125
                 URL: https://issues.apache.org/jira/browse/FELIX-2125
             Project: Felix
          Issue Type: Improvement
          Components: Web Console
            Reporter: Valentin Valchev
         Attachments: bundle_headers_localization.patch

The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.

The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()

The locale is always taken from the HTTP request. 
The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2125) Localization of the bundle headers & bundle name

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev updated FELIX-2125:
------------------------------------

    Attachment: bundle_headers_localization.patch

update the patch - now updates also
- license plugin
- services plugin

and also update the sorting by bundle name, to use locale

> Localization of the bundle headers & bundle name
> ------------------------------------------------
>
>                 Key: FELIX-2125
>                 URL: https://issues.apache.org/jira/browse/FELIX-2125
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>            Reporter: Valentin Valchev
>         Attachments: bundle_headers_localization.patch
>
>
> The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.
> The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()
> The locale is always taken from the HTTP request. 
> The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2125) Localization of the bundle headers & bundle name

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev updated FELIX-2125:
------------------------------------

    Attachment:     (was: bundle_headers_localization.patch)

> Localization of the bundle headers & bundle name
> ------------------------------------------------
>
>                 Key: FELIX-2125
>                 URL: https://issues.apache.org/jira/browse/FELIX-2125
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>            Reporter: Valentin Valchev
>
> The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.
> The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()
> The locale is always taken from the HTTP request. 
> The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (FELIX-2125) Localization of the bundle headers & bundle name

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed FELIX-2125.
-----------------------------------


> Localization of the bundle headers & bundle name
> ------------------------------------------------
>
>                 Key: FELIX-2125
>                 URL: https://issues.apache.org/jira/browse/FELIX-2125
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>            Reporter: Valentin Valchev
>            Assignee: Felix Meschberger
>             Fix For: webconsole-3.0.0
>
>         Attachments: bundle_headers_localization.patch
>
>
> The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.
> The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()
> The locale is always taken from the HTTP request. 
> The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (FELIX-2125) Localization of the bundle headers & bundle name

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved FELIX-2125.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: webconsole-3.0.0

Thanks for providing the patch.

I agree that leaving the locale in English is reasonable for the ConfigurationPrinter.

I have applied it with a small change in Rev. 918431: The Comparator is created each time for the locale instead of synchronizing on the comparator and setting the locale field. IMHO this is cleaner and the cost of creating the comparator instance is close zero.



> Localization of the bundle headers & bundle name
> ------------------------------------------------
>
>                 Key: FELIX-2125
>                 URL: https://issues.apache.org/jira/browse/FELIX-2125
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>            Reporter: Valentin Valchev
>            Assignee: Felix Meschberger
>             Fix For: webconsole-3.0.0
>
>         Attachments: bundle_headers_localization.patch
>
>
> The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.
> The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()
> The locale is always taken from the HTTP request. 
> The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (FELIX-2125) Localization of the bundle headers & bundle name

Posted by "Valentin Valchev (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Valentin Valchev updated FELIX-2125:
------------------------------------

    Attachment: bundle_headers_localization.patch

> Localization of the bundle headers & bundle name
> ------------------------------------------------
>
>                 Key: FELIX-2125
>                 URL: https://issues.apache.org/jira/browse/FELIX-2125
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>            Reporter: Valentin Valchev
>         Attachments: bundle_headers_localization.patch
>
>
> The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.
> The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()
> The locale is always taken from the HTTP request. 
> The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (FELIX-2125) Localization of the bundle headers & bundle name

Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/FELIX-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger reassigned FELIX-2125:
----------------------------------------

    Assignee: Felix Meschberger

> Localization of the bundle headers & bundle name
> ------------------------------------------------
>
>                 Key: FELIX-2125
>                 URL: https://issues.apache.org/jira/browse/FELIX-2125
>             Project: Felix
>          Issue Type: Improvement
>          Components: Web Console
>            Reporter: Valentin Valchev
>            Assignee: Felix Meschberger
>         Attachments: bundle_headers_localization.patch
>
>
> The web console now supports localization. Unfortunately the Bundles plugin is limited only to localization of the plugin. It can and should display localized bundle names and manifest headers.
> The attached patch updates it to use Bundle.getHeaders(locale) instead of Bundle.getHeaders()
> The locale is always taken from the HTTP request. 
> The only exception is when printing the configuration. In this case Locale.ENGLISH is used - the printed configuration can be used mostly by developers and support engineers, so English is better than any other.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.