You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2011/07/27 00:33:09 UTC
[jira] [Created] (HIVE-2310) CREATE EXTERNAL TABLE should require a
valid LOCATION clause
CREATE EXTERNAL TABLE should require a valid LOCATION clause
------------------------------------------------------------
Key: HIVE-2310
URL: https://issues.apache.org/jira/browse/HIVE-2310
Project: Hive
Issue Type: Bug
Components: SQL
Reporter: Carl Steinbach
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2310) CREATE EXTERNAL TABLE should require a
valid LOCATION clause
Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Franklin Hu updated HIVE-2310:
------------------------------
Attachment: hive-2310.1.patch
initial patch
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Franklin Hu reassigned HIVE-2310:
---------------------------------
Assignee: Franklin Hu
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080270#comment-13080270 ]
John Sichi commented on HIVE-2310:
----------------------------------
Non-native external tables (such as HBase tables) should neither require nor allow a LOCATION clause.
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082134#comment-13082134 ]
Ashutosh Chauhan commented on HIVE-2310:
----------------------------------------
What about following:
{code}
create table mytbl (a string) location '/tmp/tbl';
{code}
Is it fine to allow location for a table without it being 'external' ? I think semantics should be if you want to specify location then table must be external.
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2310) CREATE EXTERNAL TABLE should require a
valid LOCATION clause
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2310:
---------------------------------
Status: Open (was: Patch Available)
@Franklin: Looks like the patch has gone stale. If you rebase it I will take a look. Thanks.
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082127#comment-13082127 ]
jiraposter@reviews.apache.org commented on HIVE-2310:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1444/
-----------------------------------------------------------
Review request for John Sichi and Carl Steinbach.
Summary
-------
-Require the user to specify a valid LOCATION clause for CREATE EXTERNAL TABLE statements (except non-native tables).
-Throw an error if the user specifies a LOCATION that is a subdirectory of hive.metastore.warehouse.dir
This addresses bug hive-2310.
https://issues.apache.org/jira/browse/hive-2310
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1155176
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1155176
trunk/ql/src/test/queries/clientnegative/create_external.q PRE-CREATION
trunk/ql/src/test/queries/clientnegative/external2.q 1155176
trunk/ql/src/test/queries/clientpositive/alter2.q 1155176
trunk/ql/src/test/queries/clientpositive/create_like.q 1155176
trunk/ql/src/test/queries/clientpositive/create_like_view.q 1155176
trunk/ql/src/test/results/clientnegative/create_external.q.out PRE-CREATION
trunk/ql/src/test/results/clientnegative/external2.q.out 1155176
trunk/ql/src/test/results/clientpositive/alter2.q.out 1155176
trunk/ql/src/test/results/clientpositive/create_like.q.out 1155176
trunk/ql/src/test/results/clientpositive/create_like_view.q.out 1155176
Diff: https://reviews.apache.org/r/1444/diff
Testing
-------
unit tests pass
Thanks,
Franklin
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2310) CREATE EXTERNAL TABLE should require a
valid LOCATION clause
Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Franklin Hu updated HIVE-2310:
------------------------------
Attachment: hive-2310.2.patch
Rebase since patch was stale
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch, hive-2310.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13080265#comment-13080265 ]
Franklin Hu commented on HIVE-2310:
-----------------------------------
Implementing the above changes seems to break TestHBaseCliDriver_hbase_queries.q
Some EXTERNAL tables are created in that test but they throw an error if I try to specify a LOCATION.
Any thoughts?
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "Thiruvel Thirumoolan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082603#comment-13082603 ]
Thiruvel Thirumoolan commented on HIVE-2310:
--------------------------------------------
@Ashutosh, HIVE-109 deals with restricting location only to external tables.
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2310) CREATE EXTERNAL TABLE should require a
valid LOCATION clause
Posted by "Franklin Hu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Franklin Hu updated HIVE-2310:
------------------------------
Fix Version/s: 0.8.0
Status: Patch Available (was: Open)
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Fix For: 0.8.0
>
> Attachments: hive-2310.1.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2310) CREATE EXTERNAL TABLE should require a
valid LOCATION clause
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2310:
---------------------------------
Fix Version/s: (was: 0.8.0)
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
> Assignee: Franklin Hu
> Attachments: hive-2310.1.patch, hive-2310.2.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2310) CREATE EXTERNAL TABLE should require
a valid LOCATION clause
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13071404#comment-13071404 ]
Carl Steinbach commented on HIVE-2310:
--------------------------------------
CREATE EXTERNAL TABLE does not require the user to specify a LOCATION clause:
{code}
hive> CREATE EXTERNAL TABLE ext(a INT);
OK
hive> DESCRIBE FORMATTED ext;
...
Location: file:/user/hive/warehouse/ext <--- NOT GOOD
Table Type: EXTERNAL_TABLE
hive>
{code}
We should make the following changes:
* Require the user to specify a valid LOCATION clause for CREATE EXTERNAL TABLE statements.
* Throw an error if the user specifies a LOCATION that is a subdirectory of hive.metastore.warehouse.dir
> CREATE EXTERNAL TABLE should require a valid LOCATION clause
> ------------------------------------------------------------
>
> Key: HIVE-2310
> URL: https://issues.apache.org/jira/browse/HIVE-2310
> Project: Hive
> Issue Type: Bug
> Components: SQL
> Reporter: Carl Steinbach
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira