You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/12/14 13:41:00 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #10157: Refactor `StorageData#id` to the new StorageID object from a String type.

wu-sheng commented on PR #10157:
URL: https://github.com/apache/skywalking/pull/10157#issuecomment-1351372035

   **Notice, after this change, should be no feature change.**
   
   _I noticed, during the changes, some codes are using an object rather than an explicit String type, which could be missed from compiling level check._ 
   This is the risk I will bring bugs due to this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org