[jira] [Commented] (HBASE-16584) Backport the new ipc implementation in HBASE-16432 to branch-1

["Duo Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898629#comment-15898629 ] 

Duo Zhang commented on HBASE-16584:
-----------------------------------

Let me pick this up. We decide to upgrade to HBase-1.x late this year and we want to use async client as our internal code base is jdk8 only. So if master and branch-1 can share the same rpc implementation, it is much easier for us to backport the async client stuffs to branch-1 in our internal version.

> Backport the new ipc implementation in HBASE-16432 to branch-1
> --------------------------------------------------------------
>
>                 Key: HBASE-16584
>                 URL: https://issues.apache.org/jira/browse/HBASE-16584
>             Project: HBase
>          Issue Type: Task
>            Reporter: Duo Zhang
>
> Two problems.
> First, as RpcCliemtImpl is the default implementation on branch-1, we need to confirm that the modification on master does not make it slower. I'm not sure but I used a big lock to protect everything in the new implementation, so it may have bad impact on performance.
> Second, some configurations of the old AsyncRpcClient is gone. Such as "hbase.rpc.client.threads.max" and "hbase.rpc.client.nativetransport". Now You could pass a EventLoopGroup object directly through a helper class which makes it more flexible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)