You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/11 11:21:43 UTC
[GitHub] [flink] twalthr commented on a change in pull request #9079:
[FLINK-13208][table-planner][table-planner-blink] Update Notice files after
adding commons-codec to table package.
twalthr commented on a change in pull request #9079: [FLINK-13208][table-planner][table-planner-blink] Update Notice files after adding commons-codec to table package.
URL: https://github.com/apache/flink/pull/9079#discussion_r302491231
##########
File path: flink-table/flink-table-planner-blink/pom.xml
##########
@@ -341,6 +347,18 @@ under the License.
<pattern>com.fasterxml</pattern>
<shadedPattern>org.apache.flink.calcite.shaded.com.fasterxml</shadedPattern>
</relocation>
+ <relocation>
Review comment:
Why do we need Apache commons? Actually it took me quite some time last year to reduce the number of potentially conflicting dependencies. `EncodingUtils` has the most commonly used methods. Just adding a dependency because of one method doesn't seem right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services