[GitHub] metamodel issue #156: Checkstyle integration

[tomatophantastico <gi...@git.apache.org>]

Github user tomatophantastico commented on the issue:

    https://github.com/apache/metamodel/pull/156
  
    First, at this moment i do not see a merit in voting about complexity rules:
    As long as there is no one out there who wants to do refactor those massive amounts if code to fit those rules, there is no need to codify it. 
    Reworks of code, i guess, should always improve their readability.
    
    Second, the JDBC test is failing again, locally this works, any idea what may cause this?
    
    Third, the lambdas (@LosD ): This seems to be fixed.
    However, as the Contribute.md states indention is 4 spaces, they are indented the same level as code blocks. IMHO this is ok, but not grate and not the default behaviour of most IDE. In the code you can find different indentions (4 & 6 spaces).
    
    Indention is currently just a warning, so you might want to check yourself what you prefer.


---