You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ignite.apache.org by dp...@apache.org on 2018/09/25 16:37:12 UTC
[ignite-teamcity-bot] branch master updated: Reference to
documentation was added; Code style changes
This is an automated email from the ASF dual-hosted git repository.
dpavlov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ignite-teamcity-bot.git
The following commit(s) were added to refs/heads/master by this push:
new 4576ba1 Reference to documentation was added; Code style changes
4576ba1 is described below
commit 4576ba1342bac2505b15f0a511c7789258a21b52
Author: Dmitriy Pavlov <dp...@apache.org>
AuthorDate: Tue Sep 25 19:37:10 2018 +0300
Reference to documentation was added; Code style changes
---
README.md | 9 +++++-
.../apache/ignite/ci/IgniteTeamcityConnection.java | 34 ++++++++++++----------
2 files changed, 27 insertions(+), 16 deletions(-)
diff --git a/README.md b/README.md
index 6e4f95a..ffa931b 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
# ignite-teamcity-helper
-Ignite TC Helper/MTCGA.bot is [Apache Ignite](https://ignite.apache.org/)-based cache over [JetBrains TeamCity](https://jetbrains.ru/products/teamcity/) server(s).
+[Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot) (MTCGA.bot) is [Apache Ignite](https://ignite.apache.org/)-based cache over [JetBrains TeamCity](https://jetbrains.ru/products/teamcity/) server(s).
This tool intended to monitor [Apache Ignite Teamcity](https://ci.ignite.apache.org/) where [Apache Ignite](https://ignite.apache.org/) is tested.
@@ -24,6 +24,13 @@ In can be changed with org.apache.ignite.ci.ITcHelper.TEAMCITY_HELPER_HOME syste
Examples of configs can be found in [conf](conf) directory.
+### Code inspections, styles and abbreviation rules.
+[Code style](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) is inherited from Apache Ignite.
+Please install following components for development using IntelliJ IDEA
+* Install [Abbreviation Plugin](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules#AbbreviationRules-IntelliJIdeaPlugin)
+* Apply [Code Inspection Profile](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-C.CodeInspection)
+* Configure [IDEA Codestyle](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-A.ConfigureIntelliJIDEAcodestyle)
+
### Build
Build can be done using following commands
- gradle clean
diff --git a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
index e44c4cc..070f4b2 100644
--- a/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
+++ b/ignite-tc-helper-web/src/main/java/org/apache/ignite/ci/IgniteTeamcityConnection.java
@@ -534,41 +534,44 @@ public class IgniteTeamcityConnection implements ITeamcity {
return new ProblemOccurrences();
}
- @Override
+ /** {@inheritDoc} */
@AutoProfiling
- public TestOccurrences getTests(String href, String normalizedBranch) {
+ @Override public TestOccurrences getTests(String href, String normalizedBranch) {
return getJaxbUsingHref(href, TestOccurrences.class);
}
- @Override
+ /** {@inheritDoc} */
@AutoProfiling
- public Statistics getBuildStatistics(String href) {
+ @Override public Statistics getBuildStatistics(String href) {
return getJaxbUsingHref(href, Statistics.class);
}
- @Override
+ /** {@inheritDoc} */
@AutoProfiling
- public CompletableFuture<TestOccurrenceFull> getTestFull(String href) {
+ @Override public CompletableFuture<TestOccurrenceFull> getTestFull(String href) {
return supplyAsync(() -> getJaxbUsingHref(href, TestOccurrenceFull.class), executor);
}
- @Override
+ /** {@inheritDoc} */
@AutoProfiling
- public Change getChange(String href) {
+ @Override public Change getChange(String href) {
return getJaxbUsingHref(href, Change.class);
}
- @Override
+ /** {@inheritDoc} */
@AutoProfiling
- public ChangesList getChangesList(String href) {
+ @Override public ChangesList getChangesList(String href) {
return getJaxbUsingHref(href, ChangesList.class);
}
/** {@inheritDoc} */
- @Override
@AutoProfiling
- public IssuesUsagesList getIssuesUsagesList(String href) { return getJaxbUsingHref(href, IssuesUsagesList.class); }
+ @Override public IssuesUsagesList getIssuesUsagesList(String href) { return getJaxbUsingHref(href, IssuesUsagesList.class); }
+ /**
+ * @param href Href.
+ * @param elem Element class.
+ */
private <T> T getJaxbUsingHref(String href, Class<T> elem) {
return sendGetXmlParseJaxb(host + (href.startsWith("/") ? href.substring(1) : href), elem);
}
@@ -600,13 +603,14 @@ public class IgniteTeamcityConnection implements ITeamcity {
}
/** {@inheritDoc} */
- @AutoProfiling @Override public List<BuildRef> getFinishedBuildsIncludeSnDepFailed(String projectId, String branch) {
+ @AutoProfiling
+ @Override public List<BuildRef> getFinishedBuildsIncludeSnDepFailed(String projectId, String branch) {
return getBuildsInState(projectId, branch, BuildRef.STATE_FINISHED, null);
}
/** {@inheritDoc} */
-
- @AutoProfiling @Override public List<BuildRef> getFinishedBuildsIncludeSnDepFailed(String projectId, String branch, Integer sinceBuildId) {
+ @AutoProfiling
+ @Override public List<BuildRef> getFinishedBuildsIncludeSnDepFailed(String projectId, String branch, Integer sinceBuildId) {
return getBuildsInState(projectId, branch, BuildRef.STATE_FINISHED, sinceBuildId);
}