[GitHub] mistercrunch commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #4756: Improve xAxis ticks, thinner bottom margin
URL: https://github.com/apache/incubator-superset/pull/4756#discussion_r179658357
 
 

 ##########
 File path: superset/assets/javascripts/utils/common.js
 ##########
 @@ -86,3 +86,12 @@ export function getShortUrl(longUrl, callback) {
     },
   });
 }
+
+export function isTruthy(obj) {
 
 Review comment:
   It has to do with backward compatibility here. There's been a few instances of `CheckboxControl`  becoming a `SelectControl`. In this case the `show_brush` used to be checkbox and now is `auto`, `Yes` or 'No'.
   
   Since it's not the first time and won't be the last, we decided to go this route. 
   
   The alternatives would be to either:
   * write database migrations to alter all slices and replace `True` with `'Yes'` but that's more work and db migration have maintenance overhead.
   * systematically use `if (fd.show_brush === true || fd.show_brush === 'yes')` everywhere

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services