You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/11 07:51:06 UTC
[GitHub] [dubbo-go] codecov-io commented on pull request #510: [WIP] Ftr : add UnRegister and UnSubscribe for zookeeper Registry
codecov-io commented on pull request #510:
URL: https://github.com/apache/dubbo-go/pull/510#issuecomment-626534687
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=h1) Report
> Merging [#510](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/6a558d875f02f41f52cb97c1e2ce17f1c6031293&el=desc) will **decrease** coverage by `0.29%`.
> The diff coverage is `15.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #510 +/- ##
=======================================================
- Coverage 66.81% 66.52% -0.30%
=======================================================
Files 196 196
Lines 10125 10144 +19
=======================================================
- Hits 6765 6748 -17
- Misses 2708 2743 +35
- Partials 652 653 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `68.05% <0.00%> (-5.08%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `67.27% <0.00%> (-3.89%)` | :arrow_down: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `56.52% <0.00%> (-1.91%)` | :arrow_down: |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `43.24% <50.00%> (-0.60%)` | :arrow_down: |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `46.28% <50.00%> (+0.12%)` | :arrow_up: |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `62.31% <0.00%> (-10.15%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `55.55% <0.00%> (-1.71%)` | :arrow_down: |
| [protocol/dubbo/client.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vY2xpZW50Lmdv) | `67.87% <0.00%> (-1.22%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/510/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `56.07% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=footer). Last update [6a558d8...69ace5e](https://codecov.io/gh/apache/dubbo-go/pull/510?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org