[GitHub] [incubator-paimon] TyrantLucifer commented on a diff in pull request #714: [core] support JDK 11

["TyrantLucifer (via GitHub)" <gi...@apache.org>]

TyrantLucifer commented on code in PR #714:
URL: https://github.com/apache/incubator-paimon/pull/714#discussion_r1147874984


##########
.github/workflows/e2e-tests-1.14.yml:
##########
@@ -32,10 +32,11 @@ jobs:
     steps:
       - name: Checkout code
         uses: actions/checkout@v2
-      - name: Set up JDK 1.8
-        uses: actions/setup-java@v1
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
         with:
-          java-version: 1.8
+          java-version: '11'

Review Comment:
   Hi @legendtkl , I have a question, if you change it from 8 to 11, it will not execute jdk 8 test, I think maybe you should use `strategy.metrix` to specify both versions



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org