[GitHub] [commons-imaging] kinow commented on issue #49: Add support for EXIF 2.32

[GitBox <gi...@apache.org>]

kinow commented on issue #49: Add support for EXIF 2.32
URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-535682893
 
 
   Hi @GITNE 
   
   >I have added terminal newlines where applicable but Travis CI still fails for some unrelated reason.
   
   You have to rebase your branch on master. I've fixed the Javadoc error on JVM 13. So once rebased, this PR should pass Travis with no issues 🤞 . Do you intend to modify anything else in the PR? Add any feature/code?
   
   >Btw, personally I consider tools which require you to put a terminal newline in your files to be broken or to have a badly implemented parser. That pseudo argument for terminal newlines where stream processing concatenated files my lead to undesired behavior is dumb. It is naive to assume that processing concatenated files and processing files separately will or should always produce identical results. It is the file format that governs parsing not the mode of processing.
   
   Just to clarify, the newline here is for git. I believe it came from unix where it was good practice to have the newline. Not sure if there's a practical reason for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services