You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/08 13:44:05 UTC

[GitHub] [pulsar] Technoboy- commented on a change in pull request #14141: [Broker] Make PersistentTopicsBase#internalUpdatePartitionedTopic async

Technoboy- commented on a change in pull request #14141:
URL: https://github.com/apache/pulsar/pull/14141#discussion_r801643597



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java
##########
@@ -2265,7 +2265,7 @@ public void testFailedUpdatePartitionedTopic() throws Exception {
 
         try {
             admin.topics().updatePartitionedTopic(partitionedTopicName, newPartitions, false, false);
-        } catch (PulsarAdminException.PreconditionFailedException e) {
+        } catch (Exception e) {

Review comment:
       Yes, as we change `updatePartitionedTopic` from sync to async, the exception is wrapped by CompletionException




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org