You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/08 21:50:00 UTC

[jira] [Commented] (IO-572) Extract out replicated code in org.apache.commons.io.FileUtils

    [ https://issues.apache.org/jira/browse/IO-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391953#comment-16391953 ] 

ASF GitHub Bot commented on IO-572:
-----------------------------------

GitHub user pranet opened a pull request:

    https://github.com/apache/commons-io/pull/57

    [IO-572] Extract out replicated code in org.apache.commons.io.FileUtils

    Created two additional private methods which hold the replicated code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pranet/commons-io master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-io/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 8e1807b89e6e78ada27a1c52699a500345a8c201
Author: Pranet Verma <pr...@...>
Date:   2018-03-08T21:06:10Z

    Extract out duplicate code from move methods

commit 5f2c97de90740e5dcf1102d33ee19ff21c4f2252
Author: Pranet Verma <pr...@...>
Date:   2018-03-08T21:40:09Z

    Extract out duplicate code from list file/directory methods

----


> Extract out replicated code in org.apache.commons.io.FileUtils
> --------------------------------------------------------------
>
>                 Key: IO-572
>                 URL: https://issues.apache.org/jira/browse/IO-572
>             Project: Commons IO
>          Issue Type: Improvement
>    Affects Versions: 2.6
>            Reporter: Pranet Verma
>            Priority: Minor
>
> There is some duplicate code in the moveFile / moveDirectory methods as well as in the listFiles and listFilesAndDirectoriesMethod 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)