You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@reef.apache.org by do...@apache.org on 2015/10/13 06:43:36 UTC
incubator-reef git commit: [REEF-709/710/711] Act on obsoletes in
CustomTraceLevel, CommandLineArguments and CustomTraceListeners
Repository: incubator-reef
Updated Branches:
refs/heads/master f478f25a0 -> 1f88736d0
[REEF-709/710/711] Act on obsoletes in CustomTraceLevel, CommandLineArguments and CustomTraceListeners
This converts constructors and setters for these classes to private.
JIRA:
[REEF-709](https://issues.apache.org/jira/browse/REEF-709)
[REEF-710](https://issues.apache.org/jira/browse/REEF-710)
[REEF-711](https://issues.apache.org/jira/browse/REEF-711)
Pull request:
This closes #560
Project: http://git-wip-us.apache.org/repos/asf/incubator-reef/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-reef/commit/1f88736d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-reef/tree/1f88736d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-reef/diff/1f88736d
Branch: refs/heads/master
Commit: 1f88736d0307abc38edde0a1dd49a8775f3546a6
Parents: f478f25
Author: Mariia Mykhailova <ma...@apache.org>
Authored: Mon Oct 12 12:47:13 2015 -0700
Committer: Dongjoon Hyun <do...@apache.org>
Committed: Tue Oct 13 13:42:36 2015 +0900
----------------------------------------------------------------------
lang/cs/Org.Apache.REEF.Driver/Bridge/CommandLineArguments.cs | 7 ++-----
lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceLevel.cs | 7 ++-----
lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceListeners.cs | 7 ++-----
3 files changed, 6 insertions(+), 15 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/1f88736d/lang/cs/Org.Apache.REEF.Driver/Bridge/CommandLineArguments.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/CommandLineArguments.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/CommandLineArguments.cs
index cd3f082..1fa287a 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/CommandLineArguments.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/CommandLineArguments.cs
@@ -21,18 +21,15 @@ using Org.Apache.REEF.Tang.Annotations;
namespace Org.Apache.REEF.Driver.Bridge
{
- // TODO[REEF-710] Act on the obsoletes
public sealed class CommandLineArguments
{
- [Obsolete("This constructor will be made `private` after 0.13.")]
[Inject]
- public CommandLineArguments(
+ private CommandLineArguments(
[Parameter(typeof(DriverBridgeConfigurationOptions.ArgumentSets))] ISet<string> arguments)
{
Arguments = arguments;
}
- [Obsolete("The setter will be made `private` after 0.13.")]
- public ISet<string> Arguments { get; set; }
+ public ISet<string> Arguments { get; private set; }
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/1f88736d/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceLevel.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceLevel.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceLevel.cs
index dd0bc52..769ffb5 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceLevel.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceLevel.cs
@@ -22,12 +22,10 @@ using Org.Apache.REEF.Utilities.Logging;
namespace Org.Apache.REEF.Driver.Bridge
{
- // TODO[REEF-709] Act on the obsoletes here.
public sealed class CustomTraceLevel
{
- [Obsolete("This constructor will be made `private` after 0.13.")]
[Inject]
- public CustomTraceLevel([Parameter(typeof(DriverBridgeConfigurationOptions.TraceLevel))] string traceLevel)
+ private CustomTraceLevel([Parameter(typeof(DriverBridgeConfigurationOptions.TraceLevel))] string traceLevel)
{
var level = Level.Verbose;
if (Enum.TryParse(traceLevel.ToString(CultureInfo.InvariantCulture), out level))
@@ -41,7 +39,6 @@ namespace Org.Apache.REEF.Driver.Bridge
TraceLevel = level;
}
- [Obsolete("The setter will be made `private` after 0.13.")]
- public Level TraceLevel { get; set; }
+ public Level TraceLevel { get; private set; }
}
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/incubator-reef/blob/1f88736d/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceListeners.cs
----------------------------------------------------------------------
diff --git a/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceListeners.cs b/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceListeners.cs
index 585f3e8..0e9d42c 100644
--- a/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceListeners.cs
+++ b/lang/cs/Org.Apache.REEF.Driver/Bridge/CustomTraceListeners.cs
@@ -22,18 +22,15 @@ using Org.Apache.REEF.Tang.Annotations;
namespace Org.Apache.REEF.Driver.Bridge
{
- // TODO[REEF-711] Act on the obsoletes.
public sealed class CustomTraceListeners
{
- [Obsolete("This constructor will be made `private` after 0.13.")]
[Inject]
- public CustomTraceListeners(
+ private CustomTraceListeners(
[Parameter(typeof(DriverBridgeConfigurationOptions.TraceListenersSet))] ISet<TraceListener> listeners)
{
Listeners = listeners;
}
- [Obsolete("The setter will be made `private` after 0.13.")]
- public ISet<TraceListener> Listeners { get; set; }
+ public ISet<TraceListener> Listeners { get; private set; }
}
}
\ No newline at end of file