You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by fo...@apache.org on 2022/11/03 07:16:58 UTC

[iceberg] branch master updated: Docs: Update spotless apply command for non-default versions (#6101)

This is an automated email from the ASF dual-hosted git repository.

fokko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 5687e5f0a3 Docs: Update spotless apply command for non-default versions (#6101)
5687e5f0a3 is described below

commit 5687e5f0a3cf6a1091dec989b333889a66905273
Author: Ajantha Bhat <aj...@gmail.com>
AuthorDate: Thu Nov 3 12:46:53 2022 +0530

    Docs: Update spotless apply command for non-default versions (#6101)
    
    * Docs: Update spotless apply command for non-default versions
    
    While working on https://github.com/apache/iceberg/pull/6096, I learnt that `./gradlew spotlessApply` only works on default versions.
    I assumed that it works for all the folders. Which was not true.
    
    Hence, updating the document for new users.
    
    * Adding example
    
    * Remove filnk 1.13
---
 README.md | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 1b3efee2bb..6ae3cd8bea 100644
--- a/README.md
+++ b/README.md
@@ -57,7 +57,9 @@ Iceberg is built using Gradle with Java 1.8 or Java 11.
 
 * To invoke a build and run tests: `./gradlew build`
 * To skip tests: `./gradlew build -x test -x integrationTest`
-* To fix code style: `./gradlew spotlessApply`
+* To fix code style for default versions: `./gradlew spotlessApply`
+  To fix code style for non-default versions, the following flags need to be passed: `-DsparkVersions`, `-DflinkVersions`, `-DhiveVersions`.
+  Example: `./gradlew spotlessApply -DflinkVersions=1.14,1.15 -DsparkVersions=2.4,3.0,3.1,3.2,3.3 -DhiveVersions=2,3`
 
 Iceberg table support is organized in library modules: