You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "AmatyaAvadhanula (via GitHub)" <gi...@apache.org> on 2023/01/24 12:22:59 UTC
[GitHub] [tinkerpop] AmatyaAvadhanula opened a new pull request, #1950: TINKERPOP-2647 Deactivate active plugins during Uninstallation
AmatyaAvadhanula opened a new pull request, #1950:
URL: https://github.com/apache/tinkerpop/pull/1950
Fixes https://issues.apache.org/jira/browse/TINKERPOP-2647
When a plugin is used and uninstalled without being deactivated first, the console would fail to start up. This PR aims to deactivate such plugins when uninstall is called to prevent errors.
Ran `mvn clean install` to success and performed manual testing in the Gremlin Console
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] AmatyaAvadhanula closed pull request #1950: TINKERPOP-2647 Deactivate active plugins during Uninstallation
Posted by "AmatyaAvadhanula (via GitHub)" <gi...@apache.org>.
AmatyaAvadhanula closed pull request #1950: TINKERPOP-2647 Deactivate active plugins during Uninstallation
URL: https://github.com/apache/tinkerpop/pull/1950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #1950: TINKERPOP-2647 Deactivate active plugins during Uninstallation
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1950:
URL: https://github.com/apache/tinkerpop/pull/1950#issuecomment-1401871250
# [Codecov](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1950](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (303874b) into [master](https://codecov.io/gh/apache/tinkerpop/commit/f9eaf05377657ef93276d3fad662111425381459?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9eaf05) will **decrease** coverage by `4.35%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1950 +/- ##
============================================
- Coverage 68.61% 64.27% -4.35%
============================================
Files 854 24 -830
Lines 41185 3728 -37457
Branches 5598 0 -5598
============================================
- Hits 28258 2396 -25862
+ Misses 10950 1166 -9784
+ Partials 1977 166 -1811
```
| [Impacted Files](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...p/gremlin/console/commands/UninstallCommand.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvY29tbWFuZHMvVW5pbnN0YWxsQ29tbWFuZC5ncm9vdnk=) | | |
| [...in/server/handler/WsAndHttpChannelizerHandler.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci9oYW5kbGVyL1dzQW5kSHR0cENoYW5uZWxpemVySGFuZGxlci5qYXZh) | | |
| [...emlin/process/computer/util/VertexProgramPool.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL2NvbXB1dGVyL3V0aWwvVmVydGV4UHJvZ3JhbVBvb2wuamF2YQ==) | | |
| [...ess/traversal/translator/JavascriptTranslator.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC90cmFuc2xhdG9yL0phdmFzY3JpcHRUcmFuc2xhdG9yLmphdmE=) | | |
| [...cture/util/star/StarGraphGraphSONDeserializer.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9zdHJ1Y3R1cmUvdXRpbC9zdGFyL1N0YXJHcmFwaEdyYXBoU09ORGVzZXJpYWxpemVyLmphdmE=) | | |
| [...mlin/process/traversal/step/map/TailLocalStep.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9zdGVwL21hcC9UYWlsTG9jYWxTdGVwLmphdmE=) | | |
| [...nkerpop/gremlin/server/util/TraverserIterator.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL3NlcnZlci91dGlsL1RyYXZlcnNlckl0ZXJhdG9yLmphdmE=) | | |
| [...tinkerpop/gremlin/process/traversal/Traversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9UcmF2ZXJzYWwuamF2YQ==) | | |
| [...in/process/traversal/lambda/IdentityTraversal.java](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC9sYW1iZGEvSWRlbnRpdHlUcmF2ZXJzYWwuamF2YQ==) | | |
| [.../gremlin/console/jsr223/GephiRemoteAcceptor.groovy](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z3JlbWxpbi1jb25zb2xlL3NyYy9tYWluL2dyb292eS9vcmcvYXBhY2hlL3RpbmtlcnBvcC9ncmVtbGluL2NvbnNvbGUvanNyMjIzL0dlcGhpUmVtb3RlQWNjZXB0b3IuZ3Jvb3Z5) | | |
| ... and [820 more](https://codecov.io/gh/apache/tinkerpop/pull/1950?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] AmatyaAvadhanula commented on pull request #1950: TINKERPOP-2647 Deactivate active plugins during Uninstallation
Posted by "AmatyaAvadhanula (via GitHub)" <gi...@apache.org>.
AmatyaAvadhanula commented on PR #1950:
URL: https://github.com/apache/tinkerpop/pull/1950#issuecomment-1404782064
Thank you @Cole-Greer. I'll look further to see if the approach can be simplified and base the changes off of 3.5-dev.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #1950: TINKERPOP-2647 Deactivate active plugins during Uninstallation
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #1950:
URL: https://github.com/apache/tinkerpop/pull/1950#issuecomment-1402582382
Thanks for your contributions here. Just so you are aware, we are currently in the middle of a code freeze for the upcoming 3.5.5 and 3.6.2 releases, as such there likely won't be much activity on PR's for the time being and it won't be merged until after the releases are done.
I'm not too familiar with the console codebase so I cannot comment with too much authority here but the changes look good to me. I would prefer if the solution did not require building and iterating through so many hash sets. I would hope there is a simple way to check if the specific module being uninstalled also needs to be deactivated without looking at all the plugins. Without looking into it further though I'm not sure if this is indeed possible without further changes. There should never be that many plugins installed at any time so I don't think it's a big issue as it is currently implemented.
One ask I have is that you base these changes off of the 3.5-dev branch instead of master. Our branch structure is that we target non breaking changes towards the earliest active development branch (currently 3.5-dev) and when a PR is merged, the changes will be pulled forward into the newer development branches as well (3.6-dev, master).
Please let me know if you have any questions about this or if I can help in any way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org