[jira] [Closed] (FLINK-2369) On Windows, in testFailingSortingDataSinkTask the temp file is not removed

["Chesnay Schepler (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FLINK-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chesnay Schepler closed FLINK-2369.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0

> On Windows, in testFailingSortingDataSinkTask the temp file is not removed
> --------------------------------------------------------------------------
>
>                 Key: FLINK-2369
>                 URL: https://issues.apache.org/jira/browse/FLINK-2369
>             Project: Flink
>          Issue Type: Bug
>          Components: Distributed Runtime
>         Environment: Windows 7 64-bit, JDK 8u51
>            Reporter: Gabor Gevay
>            Assignee: Gabor Gevay
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The test fails with the assert at the very end ("Temp output file has not been removed"). This happens because FileOutputFormat.tryCleanupOnError can't delete the file, because it is still open (note, that Linux happily deletes open files).
> A fix would be to have the  this.format.close();  not just in the finally block (in DataSinkTask.invoke), but also before the tryCleanupOnError call (around line 217).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)