You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Webpal <gi...@git.apache.org> on 2016/12/16 13:36:56 UTC
[GitHub] cordova-plugin-camera pull request #243: Double exif rotation on android wit...
GitHub user Webpal opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/243
Double exif rotation on android with camera
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
This solves the "correctOrientation not rotating / wrong orientation with Android camera bug"
If flag correctOrientation is set the image is rotated according to EXIF-data. After this, the original EXIF-data is added back to the image where the rotation is stil there. Result is that instead of a wrongly rotated image with EXIF-data to correct you end up with a correctly rotated image with EXIF-data that tilts the image 90 degrees.
Removing the EXIF completely solves this for me - there should be a more elegant solution to just remove the "orientation" data from the EXIF to make this a more general purpose solution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Webpal/cordova-plugin-camera patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/243.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #243
----
commit 60853d620f713651eaa2f82cf2b329b6c7730d21
Author: Webpal <ni...@webpal.se>
Date: 2016-12-16T13:35:11Z
Double exif rotation on android with camera
This solves the "correctOrientation not rotating / wrong orientation with Android camera bug"
If flag correctOrientation is set the image is rotated according to EXIF-data. After this, the original EXIF-data is added back to the image where the rotation is stil there. Result is that instead of a wrongly rotated image with EXIF-data to correct you end up with a correctly rotated image with EXIF-data that tilts the image 90 degrees.
Removing the EXIF completely solves this for me - there should be a more elegant solution to just remove the "orientation" data from the EXIF to make this a more general purpose solution.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request #243: Double exif rotation on android wit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...
Posted by sarantist <gi...@git.apache.org>.
Github user sarantist commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/243
Same problem exists for Samsung Galaxy S3, S4 and S5. All of the other test devices work as intended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/243
So, yeah, after testing this patch on a Google Pixel, I can't accept it as it is because we lose all our EXIF data if we remove this code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...
Posted by Webpal <gi...@git.apache.org>.
Github user Webpal commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/243
Not sure if this should be merged - someone should look deeper into if this is the root cause of the issue and then apply a fix that re-applies EXIF but without rotation since the image has already been rotated... This solved the issue for my particular use case on a Galaxy S7 and the conclusion that the EXIF still keeps the "rotation 90 degrees" info when reapplied is just a theory that solved the issue for me. The final image should however probably stil have the EXIF data applied (just not the rotation part...)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/243
OK, found the cause of the issue. Just dumping EXIF isn't the answer. I'm going to close this in favour of this PR: https://github.com/apache/cordova-plugin-camera/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...
Posted by dantheman213 <gi...@git.apache.org>.
Github user dantheman213 commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/243
I am having this problem and it is incredibly annoying :/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera issue #243: Double exif rotation on android with camer...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/243
What device does this happen to? We've seen reports of Samsung devices that have had that problem, and if we're already writing the EXIF with the rest of the data, there's no need to write EXIF twice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org