You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/02/23 17:33:55 UTC

[GitHub] [commons-io] XenoAmess opened a new pull request #208: fix ci error on jdk17

XenoAmess opened a new pull request #208:
URL: https://github.com/apache/commons-io/pull/208


   As title.
   Not a great thing, so do not think need a JIRA ticket.,


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] XenoAmess commented on pull request #208: fix ci error on jdk17

Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #208:
URL: https://github.com/apache/commons-io/pull/208#issuecomment-784380141


   @garydgregory please review. thanks. this one should be very easy to review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] XenoAmess commented on pull request #208: fix ci error on jdk17

Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #208:
URL: https://github.com/apache/commons-io/pull/208#issuecomment-784737023


   > Is the mix of changing mockito AND adding a Maven profile intentional?
   
   yes. that is needed as mockito use older version of buddy which cannot deal with jdk17 binary


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #208: fix ci error on jdk17

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #208:
URL: https://github.com/apache/commons-io/pull/208#issuecomment-784550389


   Hi @XenoAmess 
   
   -1 for several reasons:
   
   Nits: The title of this PR ("fix ci error on jdk17") is misleading as (1) the PR does not fix anything, it just ignores a part of the build and (2) this is also for an Early Access Java build (jdk17-ea) and not a released Java version of 17 which is not there yet. 
   
   Main: The 17-ea build is marked in our GitHub action as "experimental" and is allowed to fail by definition. The whole point (in my mind at least) for testing on EA builds is exactly what we are seeing now: a failure. In this case, it is quite nice to see that JaCoCo is not ready for Java 17 yet; this lets anyone who cares about the FOSS ecosystem go and help JaCoCo get up to speed on Java 17. If by these efforts we can get a new release of JaCoCo out sooner for us EA adventurers, then we are all better off.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] garydgregory commented on pull request #208: fix ci error on jdk17

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #208:
URL: https://github.com/apache/commons-io/pull/208#issuecomment-784542399


   Is the mix of changing mockito AND adding a Maven profile intentional?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] coveralls commented on pull request #208: fix ci error on jdk17

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #208:
URL: https://github.com/apache/commons-io/pull/208#issuecomment-784387349


   
   [![Coverage Status](https://coveralls.io/builds/37380904/badge)](https://coveralls.io/builds/37380904)
   
   Coverage remained the same at 89.257% when pulling **54e10c431b129adc89a42e315b4d675b90624aa3 on xenoamess-fork:fix_ci_error_on_jdk17** into **6db5a0750a4e7f82ce32e61d9f9c94c75080f3c0 on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-io] XenoAmess closed pull request #208: fix ci error on jdk17

Posted by GitBox <gi...@apache.org>.
XenoAmess closed pull request #208:
URL: https://github.com/apache/commons-io/pull/208


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org