You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/12 12:14:43 UTC

[GitHub] [incubator-shardingsphere] dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos.

dongzl commented on a change in pull request #4260: refactor orchestration config for apollo & nacos. 
URL: https://github.com/apache/incubator-shardingsphere/pull/4260#discussion_r378214271
 
 

 ##########
 File path: sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/node/ConfigurationNode.java
 ##########
 @@ -57,6 +60,16 @@ public String getSchemaPath() {
         return Joiner.on("/").join("", name, ROOT, SCHEMA_NODE);
     }
     
+    /**
+     * Get schema name path.
+     * 
+     * @param schemaName schema name
+     * @return schema name path
+     */
+    public String getSchemaNamePath(final String schemaName) {
+        return Joiner.on("/").join("", name, ROOT, SCHEMA_NODE, schemaName);
 
 Review comment:
   fix code, use class constant.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services