You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/10 14:38:35 UTC
[GitHub] [hbase] Apache9 opened a new pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Apache9 opened a new pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018
…g to RegionProcedureStore
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#issuecomment-573384225
This is an important one, to make it possible to upgrade from 2.1- to 2.3+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#discussion_r367259124
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##########
@@ -298,6 +307,45 @@ private HRegion open(Configuration conf, FileSystem fs, Path rootDir) throws IOE
null);
}
+ @SuppressWarnings("deprecation")
+ private static final ImmutableSet<Class<?>> UNSUPPORTED_PROCEDURES =
+ ImmutableSet.of(RecoverMetaProcedure.class, AssignProcedure.class, UnassignProcedure.class,
+ MoveRegionProcedure.class);
+
+ /**
+ * In HBASE-20811, we have introduced a new TRSP to assign/unassign/move regions, and it is
+ * incompatible with the old AssignProcedure/UnassignProcedure/MoveRegionProcedure. So we need to
+ * make sure that there are none these procedures when upgrading. If there are, the master will
+ * quit, you need to go back to the old version to finish these procedures first before upgrading.
+ */
+ private void checkUnsupportedProcedure(Map<Class<?>, List<Procedure<?>>> procsByType)
+ throws HBaseIOException {
+ // Confirm that we do not have unfinished assign/unassign related procedures. It is not easy to
+ // support both the old assign/unassign procedures and the new TransitRegionStateProcedure as
+ // there will be conflict in the code for AM. We should finish all these procedures before
+ // upgrading.
+ for (Class<?> clazz : UNSUPPORTED_PROCEDURES) {
+ List<Procedure<?>> procs = procsByType.get(clazz);
+ if (procs != null) {
+ LOG.error(
+ "Unsupported procedure type {} found, please rollback your master to the old" +
+ " version to finish them, and then try to upgrade again. The full procedure list: {}",
+ clazz, procs);
+ throw new HBaseIOException("Unsupported procedure type " + clazz + " found");
+ }
+ }
+ // A special check for SCP, as we do not support RecoverMetaProcedure any more so we need to
+ // make sure that no one will try to schedule it but SCP does have a state which will schedule
+ // it.
+ if (procsByType.getOrDefault(ServerCrashProcedure.class, Collections.emptyList()).stream()
Review comment:
Just use eclipse formatter and it will make them in the same line if possible...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#issuecomment-574195516
Ping @ndimiduk @saintstack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#issuecomment-575095658
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 4s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 59s | master passed |
| +1 :green_heart: | compile | 0m 57s | master passed |
| +1 :green_heart: | checkstyle | 1m 32s | master passed |
| +1 :green_heart: | shadedjars | 5m 0s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
| +0 :ok: | spotbugs | 4m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 56s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 28s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed |
| +1 :green_heart: | javac | 0m 57s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 30s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 24s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 34s | the patch passed |
| +1 :green_heart: | findbugs | 4m 56s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 164m 41s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 231m 5s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.client.TestAsyncTableGetMultiThreaded |
| | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1018 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 069513a48abf 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1018/out/precommit/personality/provided.sh |
| git revision | master / 19d3bed1d4 |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/testReport/ |
| Max. process+thread count | 4825 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/3/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#discussion_r366579442
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##########
@@ -298,6 +307,45 @@ private HRegion open(Configuration conf, FileSystem fs, Path rootDir) throws IOE
null);
}
+ @SuppressWarnings("deprecation")
+ private static final ImmutableSet<Class<?>> UNSUPPORTED_PROCEDURES =
+ ImmutableSet.of(RecoverMetaProcedure.class, AssignProcedure.class, UnassignProcedure.class,
+ MoveRegionProcedure.class);
+
+ /**
+ * In HBASE-20811, we have introduced a new TRSP to assign/unassign/move regions, and it is
+ * incompatible with the old AssignProcedure/UnassignProcedure/MoveRegionProcedure. So we need to
+ * make sure that there are none these procedures when upgrading. If there are, the master will
+ * quit, you need to go back to the old version to finish these procedures first before upgrading.
+ */
+ private void checkUnsupportedProcedure(Map<Class<?>, List<Procedure<?>>> procsByType)
+ throws HBaseIOException {
+ // Confirm that we do not have unfinished assign/unassign related procedures. It is not easy to
+ // support both the old assign/unassign procedures and the new TransitRegionStateProcedure as
+ // there will be conflict in the code for AM. We should finish all these procedures before
+ // upgrading.
+ for (Class<?> clazz : UNSUPPORTED_PROCEDURES) {
+ List<Procedure<?>> procs = procsByType.get(clazz);
+ if (procs != null) {
+ LOG.error(
+ "Unsupported procedure type {} found, please rollback your master to the old" +
+ " version to finish them, and then try to upgrade again. The full procedure list: {}",
+ clazz, procs);
+ throw new HBaseIOException("Unsupported procedure type " + clazz + " found");
+ }
+ }
+ // A special check for SCP, as we do not support RecoverMetaProcedure any more so we need to
+ // make sure that no one will try to schedule it but SCP does have a state which will schedule
+ // it.
+ if (procsByType.getOrDefault(ServerCrashProcedure.class, Collections.emptyList()).stream()
Review comment:
nit: this if check reads a bit easier with some newlines
```
if (procsByType.getOrDefault(ServerCrashProcedure.class, Collections.emptyList())
.stream()
.map(p -> (ServerCrashProcedure) p)
.anyMatch(ServerCrashProcedure::isInRecoverMetaState)) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 merged pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache9 merged pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache9 commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#issuecomment-575013825
Add a UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#issuecomment-573151752
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 18s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 9s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 33s | master passed |
| +1 :green_heart: | shadedjars | 5m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 39s | master passed |
| +0 :ok: | spotbugs | 4m 53s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 50s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 33s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| -1 :x: | checkstyle | 1m 27s | hbase-server: The patch generated 5 new + 103 unchanged - 0 fixed = 108 total (was 103) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 45s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 36s | the patch passed |
| +1 :green_heart: | findbugs | 4m 57s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 162m 52s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. |
| | | 227m 14s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1018 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux b1b05b15086e 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1018/out/precommit/personality/provided.sh |
| git revision | master / 56842d04d7 |
| Default Java | 1.8.0_181 |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/1/artifact/out/diff-checkstyle-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/1/testReport/ |
| Max. process+thread count | 4879 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#discussion_r366577955
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##########
@@ -347,6 +393,22 @@ public void handleCorrupted(ProcedureIterator procIter) throws IOException {
}
}
});
+
+ // check whether there are unsupported procedures, this could happen when we are migrating from
+ // 2.1-. We used to do this in HMaster, after loading all the procedures from procedure store,
+ // but here we have to do it before migrating, otherwise, if we find some unsupported
+ // procedures, the users can not go back to 2.1 to finish them any more, as all the data are now
+ // in the new region based procedure store, which is not supported in 2.1-.
+ checkUnsupportedProcedure(activeProcsByType);
+
+ MutableLong maxProcIdFromProcs = new MutableLong(-1);
+ for (Procedure<?> proc : procs) {
+ update(proc);
+ if (proc.getProcId() > maxProcIdFromProcs.longValue()) {
+ maxProcIdFromProcs.setValue(proc.getProcId());
+ }
+ }
+ LOG.info("Migrated {} procedures", procs.size());
Review comment:
nit: "Migrated {} existing procedures from the old storage format."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#discussion_r366578815
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##########
@@ -298,6 +307,45 @@ private HRegion open(Configuration conf, FileSystem fs, Path rootDir) throws IOE
null);
}
+ @SuppressWarnings("deprecation")
+ private static final ImmutableSet<Class<?>> UNSUPPORTED_PROCEDURES =
+ ImmutableSet.of(RecoverMetaProcedure.class, AssignProcedure.class, UnassignProcedure.class,
+ MoveRegionProcedure.class);
+
+ /**
+ * In HBASE-20811, we have introduced a new TRSP to assign/unassign/move regions, and it is
+ * incompatible with the old AssignProcedure/UnassignProcedure/MoveRegionProcedure. So we need to
+ * make sure that there are none these procedures when upgrading. If there are, the master will
+ * quit, you need to go back to the old version to finish these procedures first before upgrading.
+ */
+ private void checkUnsupportedProcedure(Map<Class<?>, List<Procedure<?>>> procsByType)
+ throws HBaseIOException {
+ // Confirm that we do not have unfinished assign/unassign related procedures. It is not easy to
+ // support both the old assign/unassign procedures and the new TransitRegionStateProcedure as
+ // there will be conflict in the code for AM. We should finish all these procedures before
+ // upgrading.
+ for (Class<?> clazz : UNSUPPORTED_PROCEDURES) {
+ List<Procedure<?>> procs = procsByType.get(clazz);
+ if (procs != null) {
+ LOG.error(
+ "Unsupported procedure type {} found, please rollback your master to the old" +
Review comment:
Both of these error messages should include a link to https://hbase.apache.org/book.html#upgrade2.2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#discussion_r367527245
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionProcedureStore.java
##########
@@ -298,6 +307,45 @@ private HRegion open(Configuration conf, FileSystem fs, Path rootDir) throws IOE
null);
}
+ @SuppressWarnings("deprecation")
+ private static final ImmutableSet<Class<?>> UNSUPPORTED_PROCEDURES =
+ ImmutableSet.of(RecoverMetaProcedure.class, AssignProcedure.class, UnassignProcedure.class,
+ MoveRegionProcedure.class);
+
+ /**
+ * In HBASE-20811, we have introduced a new TRSP to assign/unassign/move regions, and it is
+ * incompatible with the old AssignProcedure/UnassignProcedure/MoveRegionProcedure. So we need to
+ * make sure that there are none these procedures when upgrading. If there are, the master will
+ * quit, you need to go back to the old version to finish these procedures first before upgrading.
+ */
+ private void checkUnsupportedProcedure(Map<Class<?>, List<Procedure<?>>> procsByType)
+ throws HBaseIOException {
+ // Confirm that we do not have unfinished assign/unassign related procedures. It is not easy to
+ // support both the old assign/unassign procedures and the new TransitRegionStateProcedure as
+ // there will be conflict in the code for AM. We should finish all these procedures before
+ // upgrading.
+ for (Class<?> clazz : UNSUPPORTED_PROCEDURES) {
+ List<Procedure<?>> procs = procsByType.get(clazz);
+ if (procs != null) {
+ LOG.error(
+ "Unsupported procedure type {} found, please rollback your master to the old" +
+ " version to finish them, and then try to upgrade again. The full procedure list: {}",
+ clazz, procs);
+ throw new HBaseIOException("Unsupported procedure type " + clazz + " found");
+ }
+ }
+ // A special check for SCP, as we do not support RecoverMetaProcedure any more so we need to
+ // make sure that no one will try to schedule it but SCP does have a state which will schedule
+ // it.
+ if (procsByType.getOrDefault(ServerCrashProcedure.class, Collections.emptyList()).stream()
Review comment:
::nod::
I disagree with eclipse formatter. I don't think it's been updated since java8.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1018: HBASE-23652 Move the unsupported procedure type check before migratin…
URL: https://github.com/apache/hbase/pull/1018#issuecomment-573283398
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 24s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 5s | master passed |
| +1 :green_heart: | compile | 1m 1s | master passed |
| +1 :green_heart: | checkstyle | 1m 33s | master passed |
| +1 :green_heart: | shadedjars | 5m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 38s | master passed |
| +0 :ok: | spotbugs | 4m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 49s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 33s | the patch passed |
| +1 :green_heart: | compile | 0m 58s | the patch passed |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | checkstyle | 1m 30s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 5m 3s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 17m 52s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. |
| +1 :green_heart: | javadoc | 0m 37s | the patch passed |
| +1 :green_heart: | findbugs | 5m 9s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 162m 59s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 31s | The patch does not generate ASF License warnings. |
| | | 228m 7s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.master.assignment.TestRegionMoveAndAbandon |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1018 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 8d9ed280d2c1 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1018/out/precommit/personality/provided.sh |
| git revision | master / 4ed466966c |
| Default Java | 1.8.0_181 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/2/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/2/testReport/ |
| Max. process+thread count | 4823 (vs. ulimit of 10000) |
| modules | C: hbase-server U: hbase-server |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1018/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services