[GitHub] [skywalking] jmjoy opened a new issue, #9319: [Bug] skywalking-eyes: dep check failed when dependencies support multi license?

[GitBox <gi...@apache.org>]

jmjoy opened a new issue, #9319:
URL: https://github.com/apache/skywalking/issues/9319

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Apache SkyWalking Component
   
   License Tools (apache/skywalking-eyes)
   
   ### What happened
   
   For example, the license of my Go project is `Apache-2.0`, I add the mod [github.com/ericlagergren/go-coreutils](https://github.com/ericlagergren/go-coreutils) to the project, the license of this mod is `GPL-3.0 and GPL-3.0-or-later`, In theory `Apache-2.0` and `GPL-3.0` are incompatible, but `dep check` passed.
   
   ### What you expected to happen
   
   dep check failed.
   
   ### How to reproduce
   
   Just run `go get github.com/ericlagergren/go-coreutils` in `skywalking-eyes`, and run `license-eye dep check`.
   
   ### Anything else
   
   Maybe the code <https://github.com/apache/skywalking-eyes/blob/f461a46e74e5fa22e9f9599a355ab4f0ac265469/pkg/deps/check.go#L67> only compare license string with `==` rather than handling the `AND`, `OR` keywords.
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 closed issue #9319: [Bug] skywalking-eyes: dep check failed when dependencies support multi license?

[GitBox <gi...@apache.org>]

kezhenxu94 closed issue #9319: [Bug] skywalking-eyes: dep check failed when dependencies support multi license?
URL: https://github.com/apache/skywalking/issues/9319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org