[GitHub] [mina-sshd] gnodet edited a comment on pull request #60: Gc socks timing

[GitBox <gi...@apache.org>]

gnodet edited a comment on pull request #60:
URL: https://github.com/apache/mina-sshd/pull/60#issuecomment-836735194


   > I can't reproduce the problem, and I'm skeptical how it can happen. The reason is that the `onChannelOpened` is called when the `SSH_MSG_CHANNEL_OPEN_CONFIRMATION` message is received for the underlying ssh channel, and afaik, it always happen before `SSH_MSG_CHANNEL_DATA`. Please provide a unit test or any way to reproduce the problem.
   
   Actually, I found a way to reproduce the problem : https://github.com/gnodet/mina-sshd/commit/26c0f090bc7a1935c19724241184f021eba6afcd
   
   The problem is indeed that the channel does not synchronise channel requests and the channel opening answer, so that messages can be sent on the channel before the `SSH_MSG_CHANNEL_OPEN_CONFIRMATION`.  This looks similar to https://issues.apache.org/jira/projects/SSHD/issues/SSHD-849.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org