You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/01 02:33:29 UTC

[GitHub] [incubator-tvm] lliu0 opened a new pull request #6605: [Parser] Fix parsing op string attributes

lliu0 opened a new pull request #6605:
URL: https://github.com/apache/incubator-tvm/pull/6605


   Attribute convertor failed to set string type field when a kTVMObjectHandle with underlying type of StringObj is passed in.  This causes relay parser error when creating conv2d op with customized data_layout string attribute.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6605: [Parser] Fix parsing op string attributes

Posted by GitBox <gi...@apache.org>.

junrushao1994 commented on pull request #6605:
URL: https://github.com/apache/incubator-tvm/pull/6605#issuecomment-701880025


   Thanks for the fix! It is definitely a bug. Would you like to fix it using the API String::CanConvertFrom? Example: https://github.com/apache/incubator-tvm/blob/master/src/runtime/graph/graph_runtime.cc#L403


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #6605: [Parser] Fix parsing op string attributes

Posted by GitBox <gi...@apache.org>.

tqchen commented on pull request #6605:
URL: https://github.com/apache/incubator-tvm/pull/6605#issuecomment-702244395


   Thanks @lliu0 !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #6605: [Parser] Fix parsing op string attributes

Posted by GitBox <gi...@apache.org>.

tqchen merged pull request #6605:
URL: https://github.com/apache/incubator-tvm/pull/6605


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org