You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2020/05/28 15:05:29 UTC

[Impala-ASF-CR] IMPALA-9743: ExprCardinalityTest should reset the test flag at the end of the test

Hello Sahil Takiar, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15987

to look at the new patch set (#3).

Change subject: IMPALA-9743: ExprCardinalityTest should reset the test flag at the end of the test
......................................................................

IMPALA-9743: ExprCardinalityTest should reset the test flag at the end of the test

In the previous patch, we set the test flag when running
ExprCardinalityTest. We should reset this flag at the end of the test.
Otherwise, some tests that require this flag unset (e.g. CatalogTest)
will fail.

Ideally, each FE test should take care of the test flag and set/unset it
explicitly. We'll gone through all tests to fix this in IMPALA-9780.

Tests:
 - Ran CORE tests

Change-Id: Id8a1085d73666db5df038dc231f14c31206375ed
---
M fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/15987/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15987
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8a1085d73666db5df038dc231f14c31206375ed
Gerrit-Change-Number: 15987
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>