[GitHub] [cxf] dkulp commented on pull request #850: [CXF-8596]:Fix infinite loop in FaultOutInterceptor

[GitBox <gi...@apache.org>]

dkulp commented on pull request #850:
URL: https://github.com/apache/cxf/pull/850#issuecomment-921946765


   My gut feeling is that this is "wrong".   This adds some additional direct "jaxws" dependencies on cxf-core which is something we've tried to reduce.   My thought would be that the WebFaultOutInterceptor should have an additional "if" near the bottom before calling the super.handleMessage(message).   Something like:
   
   ```
   } else if (f instanceof SoapFault && f.getCause() instanceof SOAPFaultException 
               && ((SOAPFaultException)f.getCause()).getFault().hasDetail()) {
               return;
   }
   ```
   That makes the new test pass, but I'm not sure if it fully solves the original problem so it would be great if you could test that and resubmit the PR with that change if it does.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org