You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/02 14:55:27 UTC
[GitHub] wujimin commented on a change in pull request #673: [SCB-504]
upgrade spring boot version
wujimin commented on a change in pull request #673: [SCB-504] upgrade spring boot version
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/673#discussion_r185525762
##########
File path: integration-tests/spring-zuul-tracing-tests/src/test/java/org/apache/servicecomb/spring/cloud/zuul/tracing/SpringCloudZuulTracingTest.java
##########
@@ -82,15 +82,18 @@ public void tracesCallsReceivedFromZuulToCalledService() throws InterruptedExcep
@Test
public void tracesFailedCallsReceivedByZuul() throws InterruptedException {
ResponseEntity<String> responseEntity = testRestTemplate.getForEntity("/dummy/rest/oops", String.class);
-
- assertThat(responseEntity.getStatusCode(), is(INTERNAL_SERVER_ERROR));
-
+ try {
+ int code = responseEntity.getStatusCode().value();
+ assertThat(code, is(590));
+ expectFailing(IllegalArgumentException.class);
Review comment:
if throw IllegalArgumentException, then failed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services