You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/14 18:57:14 UTC
[GitHub] merlimat commented on a change in pull request #1254: Fixes for multiple journals recovery
merlimat commented on a change in pull request #1254: Fixes for multiple journals recovery
URL: https://github.com/apache/bookkeeper/pull/1254#discussion_r174575227
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
##########
@@ -634,6 +639,11 @@ public Journal(File journalDirectory, ServerConfiguration conf, LedgerDirsManage
this.removePagesFromCache = conf.getJournalRemovePagesFromCache();
// read last log mark
+ if (conf.getJournalDirs().length == 1) {
+ lastMarkFileName = LAST_MARK_DEFAULT_NAME;
+ } else {
+ lastMarkFileName = LAST_MARK_DEFAULT_NAME + "." + journalIndex;
Review comment:
Yes the cookie is based on the list that comes from the config file, so changing the order will invalidate the cookie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services