DO NOT REPLY [Bug 32047] New: - "created" boolean in FacesRequestProcessor.doForward() not being set

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=32047>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=32047

"created" boolean in FacesRequestProcessor.doForward() not being set

           Summary: "created" boolean in FacesRequestProcessor.doForward()
                    not being set
           Product: Struts
           Version: 1.2.4
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Major
          Priority: Other
         Component: Struts-Faces Library
        AssignedTo: dev@struts.apache.org
        ReportedBy: cfraser@ticketweb.com


In the doForward method of latest version of FacesRequestProcessor, you
introduced a boolean, "created", which is used to determine whether or not
context.release() should be called.  In theory this should work great.  However,
"created" never gets set to anything but false, and therefore context.release()
never gets called.  I'm not sure if anyone's actually using this code, because
for me, this results in my app blowing wide open.  

Another thing to note is in the block of code just after
FacesContext.getCurrentInstance() gets called.  The context is being set twice
in this case.  Once using the HttpServletRequestWrapper and then immediately
after using the HttpServletRequest.  From the comments it appears that then 2nd
one is intended to be commented out.

Here's the source that I'm looking at:
http://svn.apache.org/viewcvs.cgi/struts/trunk/struts-faces/core-library/src/java/org/apache/struts/faces/application/FacesRequestProcessor.java

Thanks for your help, and keep up the good work.

- Chris Fraser

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org