You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2026/08/20 10:55:49 UTC
[PR] Fix liaison batch timeout for long-lived write streams [skywalking-banyandb]
hanahmily opened a new pull request, #1293:
URL: https://github.com/apache/skywalking-banyandb/pull/1293
### Fix apache/skywalking#13982
- [x] Add a unit test to verify that the fix works.
- [x] Explain briefly why the bug exists and how to fix it.
`batchPublisher` created the tier-1 liaison gRPC deadline when the first frame was published. Because the publisher lives for the external client's entire streaming write RPC, a normal long-lived client stream could consume the full timeout before its batch was sealed. Closing the publisher then surfaced one `STATUS_INTERNAL_ERROR` for every message routed through the expired per-liaison stream, even when the target liaison had already admitted the batch.
This change keeps the internal stream derived from the caller context but starts a bounded admission timer only after `CloseSend` seals the batch. Pending streams are canceled if the target liaison does not acknowledge within that window. It also raises the configurable stream, measure, and trace write timeout defaults from one minute to two minutes for additional load headroom. Data-node `ChunkedSyncService` synchronization is unchanged.
The regression uses an explicit `ROLE_LIAISON` target and only `cluster.v1.Service.Send`; it holds the publisher open beyond a short timeout, seals it, and verifies successful admission.
- [x] Fixes apache/skywalking#13982.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
### Verification
- `go test ./banyand/queue/pub -count=1`
- `go test ./banyand/liaison/grpc -count=1`
- Focused regression with `-race`
- `make pre-push`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix liaison batch timeout for long-lived write streams [skywalking-banyandb]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #1293:
URL: https://github.com/apache/skywalking-banyandb/pull/1293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix liaison batch timeout for long-lived write streams [skywalking-banyandb]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1293:
URL: https://github.com/apache/skywalking-banyandb/pull/1293#issuecomment-5354983428
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1293?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 47.46%. Comparing base ([`3530dd9`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/3530dd9b5cefaa4fef60eec91ecbfbdfcaf243c5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`01534d0`](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/01534d086a5bc93d594e6c0d772bde883e750736?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 391 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #1293 +/- ##
==========================================
+ Coverage 45.97% 47.46% +1.48%
==========================================
Files 328 246 -82
Lines 55505 22770 -32735
==========================================
- Hits 25520 10807 -14713
+ Misses 27909 10889 -17020
+ Partials 2076 1074 -1002
```
| [Flag](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1293/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [pkg](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1293/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.46% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/1293?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org