You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2017/08/29 17:57:34 UTC

[GitHub] incubator-madlib pull request #177: Graph: Refactor graph utilities

GitHub user orhankislal opened a pull request:

    https://github.com/apache/incubator-madlib/pull/177

    Graph: Refactor graph utilities

    There are some functions (such as validation, generating grouping based query
    strings etc.) that are duplicated in various files. This commit consolidates
    them into generic utility functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/orhankislal/incubator-madlib refactor_utils

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-madlib/pull/177.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #177
    
----
commit c178ea4402639ae7b3f0204570a06f0969a35b97
Author: Orhan Kislal <ok...@pivotal.io>
Date:   2017-08-22T20:46:35Z

    Graph: Refactor graph utilities
    
    There are some functions (such as validation, generating grouping based query
    strings etc.) that are duplicated in various files. This commit consolidates
    them into generic utility functions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib pull request #177: Graph: Refactor graph utilities

Posted by jingyimei <gi...@git.apache.org>.
Github user jingyimei commented on a diff in the pull request:

    https://github.com/apache/incubator-madlib/pull/177#discussion_r135934476
  
    --- Diff: src/ports/postgres/modules/graph/pagerank.py_in ---
    @@ -30,6 +30,8 @@
     import plpy
     from utilities.control import MinWarning
     from utilities.utilities import _assert
    +from utilities.utilities import _check_groups
    +from utilities.utilities import _grp_from_table
    --- End diff --
    
    Currently, these functions are not used in pagerank, but similar functionalities are implemented. We should refactor those pagerank-customized implementations to use these functions. For instance the variables `group_by_clause` and `grouping_where_clause` can be created using the above functions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-madlib issue #177: Graph: Refactor graph utilities

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:

    https://github.com/apache/incubator-madlib/pull/177
  
    
    Refer to this link for build results (access rights to CI server needed): 
    https://builds.apache.org/job/madlib-pr-build/194/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---