You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Eric Yang (JIRA)" <ji...@apache.org> on 2018/03/01 01:55:00 UTC
[jira] [Comment Edited] (YARN-7985) Service name is validated twice
in ServiceClient when a service is created
[ https://issues.apache.org/jira/browse/YARN-7985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381381#comment-16381381 ]
Eric Yang edited comment on YARN-7985 at 3/1/18 1:54 AM:
---------------------------------------------------------
+1 looks good. Thank you [~csingh]
I just committed this.
was (Author: eyang):
+1 looks good. Thank you [~csingh]
> Service name is validated twice in ServiceClient when a service is created
> --------------------------------------------------------------------------
>
> Key: YARN-7985
> URL: https://issues.apache.org/jira/browse/YARN-7985
> Project: Hadoop YARN
> Issue Type: Bug
> Components: yarn-native-services
> Affects Versions: 3.1.0
> Reporter: Chandni Singh
> Assignee: Chandni Singh
> Priority: Trivial
> Fix For: 3.2.0
>
> Attachments: YARN-7985.001.patch
>
>
> In ServiceClient.actionCreate() :
> {code:java}
> ServiceApiUtil.validateNameFormat(serviceName, getConfig());
> ServiceApiUtil.validateAndResolveService(service, fs, getConfig());{code}
> However, the ServiceApiUtil.validateAndResolveService(...), also validates the service name
> {code:java}
> if (StringUtils.isEmpty(service.getName())) {
> throw new IllegalArgumentException(
> RestApiErrorMessages.ERROR_APPLICATION_NAME_INVALID);
> }
> validateNameFormat(service.getName(), conf);{code}
> Also, {{ServiceClientTest}} which is a mock client for the ApiServer, can perform the actual validation which is performed by the {{ServiceClient}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org