You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2015/03/26 06:58:41 UTC
Review Request 32525: LENS-402 : Send status message along with error
message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32525/
-----------------------------------------------------------
Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal.
Bugs: LENS-402
https://issues.apache.org/jira/browse/LENS-402
Repository: lens
Description
-------
- Fixed status message
- Added unit tests to test the notification for failing queries
Diffs
-----
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c723
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 35a9067
lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 70f9dba
lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 0b215d8
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java PRE-CREATION
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2
Diff: https://reviews.apache.org/r/32525/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.042s]
[INFO] Lens .............................................. SUCCESS [1.761s]
[INFO] Lens API .......................................... SUCCESS [8.758s]
[INFO] Lens API for server and extensions ................ SUCCESS [7.081s]
[INFO] Lens Cube ......................................... SUCCESS [2:14.963s]
[INFO] Lens DB storage ................................... SUCCESS [11.477s]
[INFO] Lens Query Library ................................ SUCCESS [5.099s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:59.509s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [20.651s]
[INFO] Lens Server ....................................... SUCCESS [6:59.406s]
[INFO] Lens client ....................................... SUCCESS [26.098s]
[INFO] Lens CLI .......................................... SUCCESS [3:25.645s]
[INFO] Lens Examples ..................................... SUCCESS [1.238s]
[INFO] Lens Distribution ................................. SUCCESS [10.544s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:16.837s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
[INFO] Lens Regression ................................... SUCCESS [0.462s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:35.139s
[INFO] Finished at: Thu Mar 26 05:53:22 UTC 2015
[INFO] Final Memory: 108M/1283M
[INFO] ------------------------------------------------------------------------
Thanks,
Amareshwari Sriramadasu
Re: Review Request 32525: LENS-402 : Send status message along with
error message
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32525/#review77889
-----------------------------------------------------------
lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java
<https://reviews.apache.org/r/32525/#comment126231>
+1. But can be in a separate jira
- Rajat Khandelwal
On March 26, 2015, 11:28 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32525/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 11:28 a.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal.
>
>
> Bugs: LENS-402
> https://issues.apache.org/jira/browse/LENS-402
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Fixed status message
> - Added unit tests to test the notification for failing queries
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c723
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 35a9067
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 70f9dba
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 0b215d8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2
>
> Diff: https://reviews.apache.org/r/32525/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.042s]
> [INFO] Lens .............................................. SUCCESS [1.761s]
> [INFO] Lens API .......................................... SUCCESS [8.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.081s]
> [INFO] Lens Cube ......................................... SUCCESS [2:14.963s]
> [INFO] Lens DB storage ................................... SUCCESS [11.477s]
> [INFO] Lens Query Library ................................ SUCCESS [5.099s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:59.509s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [20.651s]
> [INFO] Lens Server ....................................... SUCCESS [6:59.406s]
> [INFO] Lens client ....................................... SUCCESS [26.098s]
> [INFO] Lens CLI .......................................... SUCCESS [3:25.645s]
> [INFO] Lens Examples ..................................... SUCCESS [1.238s]
> [INFO] Lens Distribution ................................. SUCCESS [10.544s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:16.837s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.462s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:35.139s
> [INFO] Finished at: Thu Mar 26 05:53:22 UTC 2015
> [INFO] Final Memory: 108M/1283M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 32525: LENS-402 : Send status message along with
error message
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32525/#review77890
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On March 26, 2015, 11:28 a.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32525/
> -----------------------------------------------------------
>
> (Updated March 26, 2015, 11:28 a.m.)
>
>
> Review request for lens, Himanshu Gahlaut, Jaideep dhok, and Rajat Khandelwal.
>
>
> Bugs: LENS-402
> https://issues.apache.org/jira/browse/LENS-402
>
>
> Repository: lens
>
>
> Description
> -------
>
> - Fixed status message
> - Added unit tests to test the notification for failing queries
>
>
> Diffs
> -----
>
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 9e3c723
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 35a9067
> lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java 70f9dba
> lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java 0b215d8
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java PRE-CREATION
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 14a4eb2
>
> Diff: https://reviews.apache.org/r/32525/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.042s]
> [INFO] Lens .............................................. SUCCESS [1.761s]
> [INFO] Lens API .......................................... SUCCESS [8.758s]
> [INFO] Lens API for server and extensions ................ SUCCESS [7.081s]
> [INFO] Lens Cube ......................................... SUCCESS [2:14.963s]
> [INFO] Lens DB storage ................................... SUCCESS [11.477s]
> [INFO] Lens Query Library ................................ SUCCESS [5.099s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:59.509s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [20.651s]
> [INFO] Lens Server ....................................... SUCCESS [6:59.406s]
> [INFO] Lens client ....................................... SUCCESS [26.098s]
> [INFO] Lens CLI .......................................... SUCCESS [3:25.645s]
> [INFO] Lens Examples ..................................... SUCCESS [1.238s]
> [INFO] Lens Distribution ................................. SUCCESS [10.544s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:16.837s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.539s]
> [INFO] Lens Regression ................................... SUCCESS [0.462s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:35.139s
> [INFO] Finished at: Thu Mar 26 05:53:22 UTC 2015
> [INFO] Final Memory: 108M/1283M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>