You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/24 19:27:16 UTC

[GitHub] [airflow] xinbinhuang commented on a change in pull request #15389: AIP-40: Deferrable Tasks

xinbinhuang commented on a change in pull request #15389:
URL: https://github.com/apache/airflow/pull/15389#discussion_r638220428



##########
File path: airflow/api_connexion/endpoints/task_instance_endpoint.py
##########
@@ -248,7 +248,7 @@ def post_clear_task_instances(dag_id: str, session=None):
         error_message = f"Dag id {dag_id} not found"
         raise NotFound(error_message)
     reset_dag_runs = data.pop('reset_dag_runs')
-    task_instances = dag.clear(get_tis=True, **data)

Review comment:
       I believe `tis` stands for `task instances`, so maybe `get_task_instances` to make it more explicit? 
   
   Another problem, `ti` is also a "public" variable as it's used in xcom, task context, macros etc. Though in general, I prefer explicit over abbreviation, I don't think it's good change to include within this PR.
   
   The same applies to the rest of `ti_instances`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org