You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2016/04/06 03:20:19 UTC

Review Request 45791: AMBARI-15725: RBAC: Help page UI edits

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45791/
-----------------------------------------------------------

Review request for Ambari, Zhe (Joe) Wang and Xi Wang.


Bugs: AMBARI-15725
    https://issues.apache.org/jira/browse/AMBARI-15725


Repository: ambari


Description
-------

Make RBAC help page table header fixed and content scrollable. Fix role listing page selector UI font issue.


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css e5ebb68 
  ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html e2222a8 

Diff: https://reviews.apache.org/r/45791/diff/


Testing
-------

Manually tested on live cluster. All unit tests passed.


Thanks,

Richard Zang

Re: Review Request 45791: AMBARI-15725: RBAC: Help page UI edits

Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45791/#review127374
-----------------------------------------------------------


Ship it!




Ship It!

- Zhe (Joe) Wang


On April 6, 2016, 1:20 a.m., Richard Zang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45791/
> -----------------------------------------------------------
> 
> (Updated April 6, 2016, 1:20 a.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang and Xi Wang.
> 
> 
> Bugs: AMBARI-15725
>     https://issues.apache.org/jira/browse/AMBARI-15725
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Make RBAC help page table header fixed and content scrollable. Fix role listing page selector UI font issue.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css e5ebb68 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/modals/RoleDetailsModal.html e2222a8 
> 
> Diff: https://reviews.apache.org/r/45791/diff/
> 
> 
> Testing
> -------
> 
> Manually tested on live cluster. All unit tests passed.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>