You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by GitBox <gi...@apache.org> on 2022/01/06 04:16:06 UTC
[GitHub] [kudu] shenxingwuying opened a new pull request #38: 18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s…
shenxingwuying opened a new pull request #38:
URL: https://github.com/apache/kudu/pull/38
create the pr, just for code-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kudu] acelyc111 commented on pull request #38: 18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s…
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on pull request #38:
URL: https://github.com/apache/kudu/pull/38#issuecomment-1006319584
Thanks for your contribution!
Please submit code review on gerrit, see: https://kudu.apache.org/docs/contributing.html#_contributing_patches_using_gerrit
For draft, you can open a pull request on your own repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kudu] acelyc111 closed pull request #38: 18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s…
Posted by GitBox <gi...@apache.org>.
acelyc111 closed pull request #38:
URL: https://github.com/apache/kudu/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kudu] acelyc111 commented on a change in pull request #38: 18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s…
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on a change in pull request #38:
URL: https://github.com/apache/kudu/pull/38#discussion_r779326416
##########
File path: src/kudu/common/generic_iterators.cc
##########
@@ -191,8 +191,8 @@ class MergeIterState : public boost::intrusive::list_base_hook<> {
}
// Returns the schema from the underlying iterator.
- const Schema& schema() const {
- return DCHECK_NOTNULL(iwb_.iter)->schema();
Review comment:
函数原型应该可以保持不变
##########
File path: src/kudu/common/iterator.h
##########
@@ -57,7 +57,7 @@ class IteratorBase {
virtual std::string ToString() const = 0;
// Return the schema for the rows which this iterator produces.
- virtual const Schema &schema() const = 0;
Review comment:
可以保持不变。
再改一波吧，应该能继续减少改动量
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kudu] shenxingwuying commented on a change in pull request #38: 18098: KUDU-3197 [tserver] optimal Schema's memory used, using std::s…
Posted by GitBox <gi...@apache.org>.
shenxingwuying commented on a change in pull request #38:
URL: https://github.com/apache/kudu/pull/38#discussion_r779291923
##########
File path: src/kudu/common/generic_iterators.cc
##########
@@ -191,8 +191,8 @@ class MergeIterState : public boost::intrusive::list_base_hook<> {
}
// Returns the schema from the underlying iterator.
- const Schema& schema() const {
- return DCHECK_NOTNULL(iwb_.iter)->schema();
Review comment:
我自提一个。 这个接口是不是不需要变化？
##########
File path: src/kudu/common/iterator.h
##########
@@ -57,7 +57,7 @@ class IteratorBase {
virtual std::string ToString() const = 0;
// Return the schema for the rows which this iterator produces.
- virtual const Schema &schema() const = 0;
Review comment:
我自己提一个。 这个接口或许保持即可。
当前schema的保持，应该new Iterator是有 options。
用它保持，应该可以的。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@kudu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org