You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "liaoxin01 (via GitHub)" <gi...@apache.org> on 2026/04/22 07:34:38 UTC
[PR] [refactor](fe) Remove enable_nereids_load switch [doris]
liaoxin01 opened a new pull request, #62703:
URL: https://github.com/apache/doris/pull/62703
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Remove the obsolete enable_nereids_load config and keep Nereids insert/load job recording on the existing loadv2 path unconditionally.
### Release note
None
### Check List (For Author)
- Test: Unit Test
- Attempted run-fe-ut.sh --run org.apache.doris.nereids.parser.EncryptSQLTest after rebasing to origin/master; the first run failed due sandboxed Maven cache writes, the rerun reached FE module compilation including fe-common and fe-core generation/compile stages before being stopped because the script builds a broad FE dependency graph.
- Behavior changed: No
- Does this need documentation: No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62703:
URL: https://github.com/apache/doris/pull/62703#issuecomment-4312680075
# FE Regression Coverage Report
Increment line coverage ` 100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62703_c8984d1fc36bcee0cd47dbaf0a92ef3c2d2e70db_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62703_c8984d1fc36bcee0cd47dbaf0a92ef3c2d2e70db_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 commented on PR #62703:
URL: https://github.com/apache/doris/pull/62703#issuecomment-4311559016
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62703:
URL: https://github.com/apache/doris/pull/62703#issuecomment-4312078887
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62703_c8984d1fc36bcee0cd47dbaf0a92ef3c2d2e70db/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62703_c8984d1fc36bcee0cd47dbaf0a92ef3c2d2e70db/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou merged PR #62703:
URL: https://github.com/apache/doris/pull/62703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62703:
URL: https://github.com/apache/doris/pull/62703#issuecomment-4312613631
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62703_c8984d1fc36bcee0cd47dbaf0a92ef3c2d2e70db/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62703_c8984d1fc36bcee0cd47dbaf0a92ef3c2d2e70db/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #62703:
URL: https://github.com/apache/doris/pull/62703#discussion_r3122302408
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2219,12 +2219,6 @@ public class Config extends ConfigBase {
* If set to true, doris will try to parse the ddl of a hive view and try to execute the query
* otherwise it will throw an AnalysisException.
*/
- @ConfField(mutable = true, varType = VariableAnnotation.EXPERIMENTAL, description = {
- "Currently defaults to true. After this function is enabled, the load statement of "
- + "the new optimizer can be used to import data. If this function fails, "
- + "the system will fall back to the old load statement."})
- public static boolean enable_nereids_load = false;
-
/**
Review Comment:
There is an orphaned/duplicated Javadoc block here (it repeats the description for querying hive views but no longer documents any config field after removing `enable_nereids_load`). Please remove this stray comment block to avoid confusion and keep the config file tidy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 commented on PR #62703:
URL: https://github.com/apache/doris/pull/62703#issuecomment-4294414176
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refactor](fe) Remove enable_nereids_load switch [doris]
Posted by "Thearas (via GitHub)" <gi...@apache.org>.
Thearas commented on PR #62703:
URL: https://github.com/apache/doris/pull/62703#issuecomment-4294398245
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org