You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/05 13:05:02 UTC

[GitHub] [cloudstack] davidjumani commented on a change in pull request #4040: [KVM] Enable PVLAN support on L2 networks

davidjumani commented on a change in pull request #4040:
URL: https://github.com/apache/cloudstack/pull/4040#discussion_r420091941



##########
File path: plugins/hypervisors/kvm/src/test/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
##########
@@ -4403,68 +4381,23 @@ public void testPvlanSetupCommandVm() {
         assertFalse(answer.getResult());
     }
 
-    @SuppressWarnings("unchecked")
-    @Test
-    public void testPvlanSetupCommandDhcpException() {

Review comment:
       Since the old way used to call the libvirt library, it could potentially throw a LibvirtException. Now that it doesn't, theres no need to catch or test whether the exception has occoured




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org