You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2014/10/24 15:25:29 UTC
Review Request 27134: Slider view: Integrate unit test with maven and
doc the commands to run unit test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27134/
-----------------------------------------------------------
Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
Bugs: ambari-7927
https://issues.apache.org/jira/browse/ambari-7927
Repository: ambari
Description
-------
This task includes two items:
1) Integrate running unit test in the maven.
So *mvn test* command compiles and runs the unit test.
2) Include README.md in the test folder for slider ui view stating the native javascript test library commands for running the unit test and integration tests
Diffs
-----
contrib/views/slider/docs/index.md bd23d14
contrib/views/slider/pom.xml cb07dd4
contrib/views/slider/src/main/resources/ui/app/assets/javascripts/jquery.mockjax.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/app/assets/tests.html 70da2a1
contrib/views/slider/src/main/resources/ui/package.json daf0943
contrib/views/slider/src/main/resources/ui/runner.js PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/index.md PRE-CREATION
contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js ddef342
pom.xml 7862e84
Diff: https://reviews.apache.org/r/27134/diff/
Testing
-------
Tests completed in 10955 milliseconds.
148 assertions of 148 passed, 0 failed.
Thanks,
Oleg Nechiporenko
Re: Review Request 27134: Slider view: Integrate unit test with maven
and doc the commands to run unit test
Posted by Andriy Babiichuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27134/#review58264
-----------------------------------------------------------
Ship it!
Ship It!
- Andriy Babiichuk
On Окт. 24, 2014, 1:25 п.п., Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27134/
> -----------------------------------------------------------
>
> (Updated Окт. 24, 2014, 1:25 п.п.)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: ambari-7927
> https://issues.apache.org/jira/browse/ambari-7927
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This task includes two items:
>
> 1) Integrate running unit test in the maven.
> So *mvn test* command compiles and runs the unit test.
>
> 2) Include README.md in the test folder for slider ui view stating the native javascript test library commands for running the unit test and integration tests
>
>
> Diffs
> -----
>
> contrib/views/slider/docs/index.md bd23d14
> contrib/views/slider/pom.xml cb07dd4
> contrib/views/slider/src/main/resources/ui/app/assets/javascripts/jquery.mockjax.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/app/assets/tests.html 70da2a1
> contrib/views/slider/src/main/resources/ui/package.json daf0943
> contrib/views/slider/src/main/resources/ui/runner.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/index.md PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js ddef342
> pom.xml 7862e84
>
> Diff: https://reviews.apache.org/r/27134/diff/
>
>
> Testing
> -------
>
> Tests completed in 10955 milliseconds.
> 148 assertions of 148 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>
Re: Review Request 27134: Slider view: Integrate unit test with maven
and doc the commands to run unit test
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27134/#review58265
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On Жов. 24, 2014, 1:25 після полудня, Oleg Nechiporenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27134/
> -----------------------------------------------------------
>
> (Updated Жов. 24, 2014, 1:25 після полудня)
>
>
> Review request for Ambari, Andriy Babiichuk and Aleksandr Kovalenko.
>
>
> Bugs: ambari-7927
> https://issues.apache.org/jira/browse/ambari-7927
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This task includes two items:
>
> 1) Integrate running unit test in the maven.
> So *mvn test* command compiles and runs the unit test.
>
> 2) Include README.md in the test folder for slider ui view stating the native javascript test library commands for running the unit test and integration tests
>
>
> Diffs
> -----
>
> contrib/views/slider/docs/index.md bd23d14
> contrib/views/slider/pom.xml cb07dd4
> contrib/views/slider/src/main/resources/ui/app/assets/javascripts/jquery.mockjax.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/app/assets/tests.html 70da2a1
> contrib/views/slider/src/main/resources/ui/package.json daf0943
> contrib/views/slider/src/main/resources/ui/runner.js PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/index.md PRE-CREATION
> contrib/views/slider/src/main/resources/ui/test/integration/processes/create_new_app_test.js ddef342
> pom.xml 7862e84
>
> Diff: https://reviews.apache.org/r/27134/diff/
>
>
> Testing
> -------
>
> Tests completed in 10955 milliseconds.
> 148 assertions of 148 passed, 0 failed.
>
>
> Thanks,
>
> Oleg Nechiporenko
>
>