[GitHub] [superset] eschutho commented on a diff in pull request #22723: feat(ssh_tunnel): Change default value for allow_ssh_tunneling in the base class

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #22723:
URL: https://github.com/apache/superset/pull/22723#discussion_r1070113263


##########
superset/db_engine_specs/base.py:
##########
@@ -193,7 +193,7 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
     engine_aliases: Set[str] = set()
     drivers: Dict[str, str] = {}
     default_driver: Optional[str] = None
-    allow_ssh_tunneling = False
+    allow_ssh_tunneling = True

Review Comment:
   This is kind of a nit, but I think your first inclination to make the default value `False` was a good one and follows convention. Can we instead flip the behavior, so something like `disable_ssh_tunneling = False` (or some name that is shorter. :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org